Use correct range for TRIO115 fix
#8933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
zanieb
approved these changes
Dec 1, 2023
|
| @@ -103,7 +103,7 @@ pub(crate) fn zero_sleep_call(checker: &mut Checker, call: &ExprCall) { | |||
| )?; | |||
| let reference_edit = | |||
| Edit::range_replacement(format!("{binding}.checkpoint"), call.func.range()); | |||
| let arg_edit = Edit::range_deletion(call.arguments.range); | |||
| let arg_edit = Edit::range_deletion(arg.range()); | |||
There was a problem hiding this comment.
Will this range be incorrect if the user uses a keyword argument?
There was a problem hiding this comment.
We probably want "replace call.arguments.range with ()".
There was a problem hiding this comment.
I'm out now but I think that should still work as arg is either a positional or keyword argument.
There was a problem hiding this comment.
But arg is just the value, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the bug where the autofix for
TRIO115was taking the entire arguments range for the fix which included the parenthesis as well. This means that the fix would remove the arguments and the parenthesis. The fix is to use the correct range.fixes: #8713
Test Plan
Update existing snapshots :)