Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore @overload and @override methods for too-many-arguments checks #8954

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Dec 1, 2023

Closes #8945.

@charliermarsh charliermarsh added the bug Something isn't working label Dec 1, 2023
@charliermarsh charliermarsh marked this pull request as ready for review December 1, 2023 18:16
@charliermarsh charliermarsh enabled auto-merge (squash) December 1, 2023 18:18
@charliermarsh charliermarsh merged commit 5510a61 into main Dec 1, 2023
16 checks passed
@charliermarsh charliermarsh deleted the charlie/override branch December 1, 2023 18:22
Copy link
Contributor

github-actions bot commented Dec 1, 2023

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+0 -41 violations, +0 -0 fixes in 41 projects)

apache/airflow (+0 -27 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-preview --select ALL

- airflow/decorators/__init__.pyi:104:9: PLR0913 Too many arguments in function definition (12 > 5)
- airflow/decorators/__init__.pyi:202:9: PLR0913 Too many arguments in function definition (12 > 5)
- airflow/decorators/__init__.pyi:256:9: PLR0913 Too many arguments in function definition (6 > 5)
- airflow/decorators/__init__.pyi:583:9: PLR0913 Too many arguments in function definition (7 > 5)
- airflow/decorators/task_group.py:179:5: PLR0913 Too many arguments in function definition (9 > 5)
- airflow/models/dag.py:1721:9: PLR0913 Too many arguments in function definition (12 > 5)
- airflow/models/dag.py:1739:9: PLR0913 Too many arguments in function definition (16 > 5)
- airflow/models/xcom.py:141:9: PLR0913 Too many arguments in function definition (8 > 5)
- airflow/models/xcom.py:170:9: PLR0913 Too many arguments in function definition (7 > 5)
- airflow/models/xcom.py:314:9: PLR0913 Too many arguments in function definition (6 > 5)
- airflow/models/xcom.py:357:9: PLR0913 Too many arguments in function definition (6 > 5)
- airflow/models/xcom.py:428:9: PLR0913 Too many arguments in function definition (8 > 5)
- airflow/models/xcom.py:467:9: PLR0913 Too many arguments in function definition (8 > 5)
- airflow/providers/common/sql/hooks/sql.py:288:9: PLR0913 Too many arguments in function definition (7 > 5)
- airflow/providers/common/sql/hooks/sql.py:300:9: PLR0913 Too many arguments in function definition (7 > 5)
- airflow/providers/databricks/hooks/databricks_sql.py:149:9: PLR0913 Too many arguments in function definition (7 > 5)
- airflow/providers/databricks/hooks/databricks_sql.py:161:9: PLR0913 Too many arguments in function definition (7 > 5)
- airflow/providers/exasol/hooks/exasol.py:166:9: PLR0913 Too many arguments in function definition (7 > 5)
- airflow/providers/exasol/hooks/exasol.py:178:9: PLR0913 Too many arguments in function definition (7 > 5)
- airflow/providers/google/cloud/hooks/gcs.py:271:9: PLR0913 Too many arguments in function definition (8 > 5)
- airflow/providers/google/cloud/hooks/gcs.py:284:9: PLR0913 Too many arguments in function definition (8 > 5)
- airflow/providers/mongo/hooks/mongo.py:146:9: PLR0913 Too many arguments in function definition (6 > 5)
- airflow/providers/mongo/hooks/mongo.py:158:9: PLR0913 Too many arguments in function definition (6 > 5)
- airflow/providers/snowflake/hooks/snowflake.py:304:9: PLR0913 Too many arguments in function definition (8 > 5)
- airflow/providers/snowflake/hooks/snowflake.py:317:9: PLR0913 Too many arguments in function definition (8 > 5)
- airflow/providers/vertica/hooks/vertica.py:136:9: PLR0913 Too many arguments in function definition (7 > 5)
- airflow/providers/vertica/hooks/vertica.py:148:9: PLR0913 Too many arguments in function definition (7 > 5)

zulip/zulip (+0 -14 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-preview --select ALL

- zerver/forms.py:355:9: PLR0913 Too many arguments in function definition (10 > 5)
- zerver/lib/request.py:215:5: PLR0913 Too many arguments in function definition (8 > 5)
- zerver/lib/request.py:231:5: PLR0913 Too many arguments in function definition (8 > 5)
- zerver/lib/request.py:247:5: PLR0913 Too many arguments in function definition (7 > 5)
- zerver/lib/request.py:262:5: PLR0913 Too many arguments in function definition (7 > 5)
- zerver/lib/request.py:277:5: PLR0913 Too many arguments in function definition (7 > 5)
- zerver/lib/test_runner.py:359:9: PLR0913 Too many arguments in function definition (6 > 5)
- zerver/lib/upload/local.py:87:9: PLR0913 Too many arguments in function definition (7 > 5)
- zerver/lib/upload/s3.py:220:9: PLR0913 Too many arguments in function definition (7 > 5)
- zerver/tests/test_auth_backends.py:1955:9: PLR0913 Too many arguments in function definition (10 > 5)
- zerver/tests/test_auth_backends.py:3467:9: PLR0913 Too many arguments in function definition (11 > 5)
- zerver/tests/test_auth_backends.py:3509:9: PLR0913 Too many arguments in function definition (11 > 5)
- zerver/tests/test_auth_backends.py:3918:9: PLR0913 Too many arguments in function definition (6 > 5)
- zerver/tornado/django_api.py:36:9: PLR0913 Too many arguments in function definition (7 > 5)

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PLR0913 41 0 41 0 0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -40 violations, +0 -0 fixes in 41 projects)

apache/airflow (+0 -25 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview --select ALL

- airflow/decorators/__init__.pyi:104:9: PLR0913 Too many arguments in function definition (12 > 5)
- airflow/decorators/__init__.pyi:202:9: PLR0913 Too many arguments in function definition (12 > 5)
- airflow/decorators/__init__.pyi:256:9: PLR0913 Too many arguments in function definition (6 > 5)
- airflow/decorators/__init__.pyi:583:9: PLR0913 Too many arguments in function definition (7 > 5)
- airflow/decorators/task_group.py:179:5: PLR0913 Too many arguments in function definition (9 > 5)
- airflow/models/dag.py:1721:9: PLR0913 Too many arguments in function definition (12 > 5)
- airflow/models/dag.py:1739:9: PLR0913 Too many arguments in function definition (16 > 5)
- airflow/models/xcom.py:141:9: PLR0913 Too many arguments in function definition (8 > 5)
- airflow/models/xcom.py:170:9: PLR0913 Too many arguments in function definition (7 > 5)
- airflow/models/xcom.py:314:9: PLR0913 Too many arguments in function definition (6 > 5)
- airflow/models/xcom.py:357:9: PLR0913 Too many arguments in function definition (6 > 5)
- airflow/models/xcom.py:428:9: PLR0913 Too many arguments in function definition (8 > 5)
- airflow/models/xcom.py:467:9: PLR0913 Too many arguments in function definition (8 > 5)
- airflow/providers/common/sql/hooks/sql.py:288:9: PLR0913 Too many arguments in function definition (7 > 5)
- airflow/providers/common/sql/hooks/sql.py:300:9: PLR0913 Too many arguments in function definition (7 > 5)
- airflow/providers/databricks/hooks/databricks_sql.py:149:9: PLR0913 Too many arguments in function definition (7 > 5)
- airflow/providers/databricks/hooks/databricks_sql.py:161:9: PLR0913 Too many arguments in function definition (7 > 5)
- airflow/providers/exasol/hooks/exasol.py:166:9: PLR0913 Too many arguments in function definition (7 > 5)
- airflow/providers/exasol/hooks/exasol.py:178:9: PLR0913 Too many arguments in function definition (7 > 5)
- airflow/providers/mongo/hooks/mongo.py:146:9: PLR0913 Too many arguments in function definition (6 > 5)
- airflow/providers/mongo/hooks/mongo.py:158:9: PLR0913 Too many arguments in function definition (6 > 5)
- airflow/providers/snowflake/hooks/snowflake.py:304:9: PLR0913 Too many arguments in function definition (8 > 5)
- airflow/providers/snowflake/hooks/snowflake.py:317:9: PLR0913 Too many arguments in function definition (8 > 5)
- airflow/providers/vertica/hooks/vertica.py:136:9: PLR0913 Too many arguments in function definition (7 > 5)
- airflow/providers/vertica/hooks/vertica.py:148:9: PLR0913 Too many arguments in function definition (7 > 5)

pandas-dev/pandas (+0 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview

- pandas/core/common.py:237:46: PLR6201 Use a `set` literal when testing for membership

zulip/zulip (+0 -14 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview --select ALL

- zerver/forms.py:355:9: PLR0913 Too many arguments in function definition (10 > 5)
- zerver/lib/request.py:215:5: PLR0913 Too many arguments in function definition (8 > 5)
- zerver/lib/request.py:231:5: PLR0913 Too many arguments in function definition (8 > 5)
- zerver/lib/request.py:247:5: PLR0913 Too many arguments in function definition (7 > 5)
- zerver/lib/request.py:262:5: PLR0913 Too many arguments in function definition (7 > 5)
- zerver/lib/request.py:277:5: PLR0913 Too many arguments in function definition (7 > 5)
- zerver/lib/test_runner.py:359:9: PLR0913 Too many arguments in function definition (6 > 5)
- zerver/lib/upload/local.py:87:9: PLR0913 Too many arguments in function definition (7 > 5)
- zerver/lib/upload/s3.py:220:9: PLR0913 Too many arguments in function definition (7 > 5)
- zerver/tests/test_auth_backends.py:1955:9: PLR0913 Too many arguments in function definition (10 > 5)
- zerver/tests/test_auth_backends.py:3467:9: PLR0913 Too many arguments in function definition (11 > 5)
- zerver/tests/test_auth_backends.py:3509:9: PLR0913 Too many arguments in function definition (11 > 5)
- zerver/tests/test_auth_backends.py:3918:9: PLR0913 Too many arguments in function definition (6 > 5)
- zerver/tornado/django_api.py:36:9: PLR0913 Too many arguments in function definition (7 > 5)

Changes by rule (2 rules affected)

code total + violation - violation + fix - fix
PLR0913 39 0 39 0 0
PLR6201 1 0 1 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: allow PLR0913 in @overriden methods
1 participant