Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary index diagnostics when value is modified #8970

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Avoid unnecessary index diagnostics when value is modified #8970

merged 1 commit into from
Dec 2, 2023

Conversation

charliermarsh
Copy link
Member

Closes #8969.

@charliermarsh charliermarsh added the bug Something isn't working label Dec 2, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) December 2, 2023 18:15
@charliermarsh charliermarsh merged commit 20ab14e into main Dec 2, 2023
16 checks passed
@charliermarsh charliermarsh deleted the charlie/value branch December 2, 2023 18:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@miccal miccal mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PLR1736 yields invalid suggestion and unsafe fix that changes semantics.
1 participant
@charliermarsh