Avoid syntax error via invalid ur string prefix #8971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Dec 2, 2023
| @@ -31,7 +31,6 @@ mod tests { | |||
| #[test_case(Rule::BlankLineWithWhitespace, Path::new("W29.py"))] | |||
| #[test_case(Rule::InvalidEscapeSequence, Path::new("W605_0.py"))] | |||
| #[test_case(Rule::InvalidEscapeSequence, Path::new("W605_1.py"))] | |||
| #[test_case(Rule::InvalidEscapeSequence, Path::new("W605_2.py"))] | |||
There was a problem hiding this comment.
I deleted W605_1.py which looks identical to W605_0.py? And then renamed W605_2.py to W605_1.py.
charliermarsh
force-pushed
the
charlie/unicode
branch
from
a0c22d8
to
3ef92ad
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a string has a Unicode prefix, we can't add the
rprefix on top of that -- we need to remove and replace it. (The Unicode prefix is redundant anyway in Python 3.)Closes #8967.