Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that from-style imports are always ordered first in __future__ #9039

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Ensure that from-style imports are always ordered first in __future__ #9039

merged 1 commit into from
Dec 7, 2023

Conversation

charliermarsh
Copy link
Member

Closes #8823.

@charliermarsh charliermarsh added bug Something isn't working internal An internal refactor or improvement isort Related to import sorting and removed internal An internal refactor or improvement labels Dec 7, 2023
@charliermarsh charliermarsh changed the title Ensure that from-style imports are always ordered first in __future__ Ensure that from-style imports are always ordered first in __future__ Dec 7, 2023
@charliermarsh charliermarsh marked this pull request as ready for review December 7, 2023 03:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh merged commit 946b308 into main Dec 7, 2023
17 checks passed
@charliermarsh charliermarsh deleted the charlie/futures branch December 7, 2023 03:56
@krehel krehel mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working isort Related to import sorting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unsorted-imports (I001) false positive when import __future__ is below from __future__ import
1 participant
@charliermarsh