Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change PLR0917 error message to match other PLR09XX messages #9308

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Change PLR0917 error message to match other PLR09XX messages #9308

merged 2 commits into from
Dec 29, 2023

Conversation

mikaelarguedas
Copy link
Contributor

Summary

Remove : for PLR0917 to make all PLR09XX message look the same

PLR0904	Too many public methods (21 > 20)
PLR0911	Too many return statements (16 > 6)
PLR0912	Too many branches (13 > 12)
PLR0913	Too many arguments in function definition (10 > 5)
PLR0915	Too many statements (118 > 50)
PLR0917	Too many positional arguments: (15/5)

Test Plan

@mikaelarguedas
homogenize PLR0917 message to match other PLR 09XX rules
32abb68 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas
update snapshots accordingly
1f7e7b8 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+2672 -2672 violations, +0 -0 fixes in 10 projects; 31 projects unchanged)

aiven/aiven-client (+32 -32 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview

+ aiven/client/argx.py:311:9: PLR0917 Too many positional arguments (10/5)
- aiven/client/argx.py:311:9: PLR0917 Too many positional arguments: (10/5)
+ aiven/client/cli.py:3633:9: PLR0917 Too many positional arguments (6/5)
- aiven/client/cli.py:3633:9: PLR0917 Too many positional arguments: (6/5)
+ aiven/client/cli.py:5697:9: PLR0917 Too many positional arguments (6/5)
- aiven/client/cli.py:5697:9: PLR0917 Too many positional arguments: (6/5)
+ aiven/client/client.py:1080:9: PLR0917 Too many positional arguments (6/5)
- aiven/client/client.py:1080:9: PLR0917 Too many positional arguments: (6/5)
+ aiven/client/client.py:1090:9: PLR0917 Too many positional arguments (6/5)
- aiven/client/client.py:1090:9: PLR0917 Too many positional arguments: (6/5)
... 54 additional changes omitted for project

apache/airflow (+1181 -1181 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview --select ALL

+ airflow/api/client/api_client.py:33:9: PLR0917 Too many positional arguments (6/5)
- airflow/api/client/api_client.py:33:9: PLR0917 Too many positional arguments: (6/5)
+ airflow/api/client/json_client.py:57:9: PLR0917 Too many positional arguments (6/5)
- airflow/api/client/json_client.py:57:9: PLR0917 Too many positional arguments: (6/5)
+ airflow/api/client/local_client.py:31:9: PLR0917 Too many positional arguments (6/5)
- airflow/api/client/local_client.py:31:9: PLR0917 Too many positional arguments: (6/5)
+ airflow/api/common/mark_tasks.py:209:5: PLR0917 Too many positional arguments (6/5)
- airflow/api/common/mark_tasks.py:209:5: PLR0917 Too many positional arguments: (6/5)
+ airflow/api/common/trigger_dag.py:34:5: PLR0917 Too many positional arguments (6/5)
- airflow/api/common/trigger_dag.py:34:5: PLR0917 Too many positional arguments: (6/5)
+ airflow/api_connexion/endpoints/dag_endpoint.py:144:5: PLR0917 Too many positional arguments (7/5)
- airflow/api_connexion/endpoints/dag_endpoint.py:144:5: PLR0917 Too many positional arguments: (7/5)
+ airflow/callbacks/callback_requests.py:114:9: PLR0917 Too many positional arguments (7/5)
- airflow/callbacks/callback_requests.py:114:9: PLR0917 Too many positional arguments: (7/5)
+ airflow/callbacks/callback_requests.py:76:9: PLR0917 Too many positional arguments (6/5)
- airflow/callbacks/callback_requests.py:76:9: PLR0917 Too many positional arguments: (6/5)
+ airflow/cli/cli_config.py:79:9: PLR0917 Too many positional arguments (11/5)
- airflow/cli/cli_config.py:79:9: PLR0917 Too many positional arguments: (11/5)
+ airflow/cli/commands/webserver_command.py:84:9: PLR0917 Too many positional arguments (7/5)
- airflow/cli/commands/webserver_command.py:84:9: PLR0917 Too many positional arguments: (7/5)
+ airflow/configuration.py:1050:9: PLR0917 Too many positional arguments (7/5)
- airflow/configuration.py:1050:9: PLR0917 Too many positional arguments: (7/5)
... 2340 additional changes omitted for project

aws/aws-sam-cli (+399 -399 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview

+ samcli/cli/cli_config_file.py:176:5: PLR0917 Too many positional arguments (7/5)
- samcli/cli/cli_config_file.py:176:5: PLR0917 Too many positional arguments: (7/5)
+ samcli/cli/global_config.py:184:9: PLR0917 Too many positional arguments (6/5)
- samcli/cli/global_config.py:184:9: PLR0917 Too many positional arguments: (6/5)
+ samcli/cli/global_config.py:223:9: PLR0917 Too many positional arguments (6/5)
- samcli/cli/global_config.py:223:9: PLR0917 Too many positional arguments: (6/5)
+ samcli/commands/_utils/options.py:195:5: PLR0917 Too many positional arguments (6/5)
- samcli/commands/_utils/options.py:195:5: PLR0917 Too many positional arguments: (6/5)
+ samcli/commands/_utils/table_print.py:103:5: PLR0917 Too many positional arguments (7/5)
- samcli/commands/_utils/table_print.py:103:5: PLR0917 Too many positional arguments: (7/5)
... 788 additional changes omitted for project

bokeh/bokeh (+54 -54 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview --select ALL

+ examples/basic/annotations/colorbar_log.py:15:5: PLR0917 Too many positional arguments (6/5)
- examples/basic/annotations/colorbar_log.py:15:5: PLR0917 Too many positional arguments: (6/5)
+ examples/models/gauges.py:48:5: PLR0917 Too many positional arguments (7/5)
- examples/models/gauges.py:48:5: PLR0917 Too many positional arguments: (7/5)
+ examples/plotting/histogram.py:17:5: PLR0917 Too many positional arguments (6/5)
- examples/plotting/histogram.py:17:5: PLR0917 Too many positional arguments: (6/5)
+ examples/topics/hierarchical/treemap.py:26:5: PLR0917 Too many positional arguments (6/5)
- examples/topics/hierarchical/treemap.py:26:5: PLR0917 Too many positional arguments: (6/5)
+ src/bokeh/client/session.py:194:5: PLR0917 Too many positional arguments (6/5)
- src/bokeh/client/session.py:194:5: PLR0917 Too many positional arguments: (6/5)
... 98 additional changes omitted for project

freedomofpress/securedrop (+15 -15 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview

+ securedrop/journalist_app/sessions.py:100:9: PLR0917 Too many positional arguments (7/5)
- securedrop/journalist_app/sessions.py:100:9: PLR0917 Too many positional arguments: (7/5)
+ securedrop/models.py:425:9: PLR0917 Too many positional arguments (7/5)
- securedrop/models.py:425:9: PLR0917 Too many positional arguments: (7/5)
+ securedrop/models.py:78:9: PLR0917 Too many positional arguments (6/5)
- securedrop/models.py:78:9: PLR0917 Too many positional arguments: (6/5)
+ securedrop/pretty_bad_protocol/_meta.py:135:9: PLR0917 Too many positional arguments (10/5)
- securedrop/pretty_bad_protocol/_meta.py:135:9: PLR0917 Too many positional arguments: (10/5)
+ securedrop/pretty_bad_protocol/_meta.py:785:9: PLR0917 Too many positional arguments (8/5)
- securedrop/pretty_bad_protocol/_meta.py:785:9: PLR0917 Too many positional arguments: (8/5)
... 20 additional changes omitted for project

fronzbot/blinkpy (+8 -8 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview

+ blinkpy/api.py:461:11: PLR0917 Too many positional arguments (6/5)
- blinkpy/api.py:461:11: PLR0917 Too many positional arguments: (6/5)
+ blinkpy/api.py:483:11: PLR0917 Too many positional arguments (6/5)
- blinkpy/api.py:483:11: PLR0917 Too many positional arguments: (6/5)
+ blinkpy/auth.py:144:15: PLR0917 Too many positional arguments (9/5)
- blinkpy/auth.py:144:15: PLR0917 Too many positional arguments: (9/5)
+ blinkpy/blinkpy.py:322:15: PLR0917 Too many positional arguments (7/5)
- blinkpy/blinkpy.py:322:15: PLR0917 Too many positional arguments: (7/5)
+ blinkpy/blinkpy.py:392:15: PLR0917 Too many positional arguments (6/5)
- blinkpy/blinkpy.py:392:15: PLR0917 Too many positional arguments: (6/5)
... 6 additional changes omitted for project

ibis-project/ibis (+110 -110 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview

+ ibis/backends/base/sql/alchemy/__init__.py:138:9: PLR0917 Too many positional arguments (9/5)
- ibis/backends/base/sql/alchemy/__init__.py:138:9: PLR0917 Too many positional arguments: (9/5)
+ ibis/backends/base/sql/alchemy/__init__.py:72:9: PLR0917 Too many positional arguments (6/5)
- ibis/backends/base/sql/alchemy/__init__.py:72:9: PLR0917 Too many positional arguments: (6/5)
+ ibis/backends/base/sql/compiler/query_builder.py:192:9: PLR0917 Too many positional arguments (15/5)
- ibis/backends/base/sql/compiler/query_builder.py:192:9: PLR0917 Too many positional arguments: (15/5)
+ ibis/backends/base/sql/compiler/select_builder.py:26:9: PLR0917 Too many positional arguments (6/5)
- ibis/backends/base/sql/compiler/select_builder.py:26:9: PLR0917 Too many positional arguments: (6/5)
+ ibis/backends/base/sql/compiler/translator.py:192:9: PLR0917 Too many positional arguments (6/5)
- ibis/backends/base/sql/compiler/translator.py:192:9: PLR0917 Too many positional arguments: (6/5)
... 210 additional changes omitted for project

pandas-dev/pandas (+662 -662 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview

+ asv_bench/benchmarks/groupby.py:490:9: PLR0917 Too many positional arguments (6/5)
- asv_bench/benchmarks/groupby.py:490:9: PLR0917 Too many positional arguments: (6/5)
+ asv_bench/benchmarks/groupby.py:573:9: PLR0917 Too many positional arguments (6/5)
- asv_bench/benchmarks/groupby.py:573:9: PLR0917 Too many positional arguments: (6/5)
+ asv_bench/benchmarks/groupby.py:576:9: PLR0917 Too many positional arguments (6/5)
- asv_bench/benchmarks/groupby.py:576:9: PLR0917 Too many positional arguments: (6/5)
+ asv_bench/benchmarks/rolling.py:108:9: PLR0917 Too many positional arguments (7/5)
- asv_bench/benchmarks/rolling.py:108:9: PLR0917 Too many positional arguments: (7/5)
+ asv_bench/benchmarks/rolling.py:123:9: PLR0917 Too many positional arguments (7/5)
- asv_bench/benchmarks/rolling.py:123:9: PLR0917 Too many positional arguments: (7/5)
+ asv_bench/benchmarks/rolling.py:214:9: PLR0917 Too many positional arguments (6/5)
- asv_bench/benchmarks/rolling.py:214:9: PLR0917 Too many positional arguments: (6/5)
... 1312 additional changes omitted for project

... Truncated remaining completed projected reports due to GitHub comment length restrictions

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PLR0917 5344 2672 2672 0 0

charliermarsh
charliermarsh approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charliermarsh charliermarsh added the bug Something isn't working label Dec 29, 2023
@charliermarsh charliermarsh merged commit d86d3bd into astral-sh:main Dec 29, 2023
17 checks passed
@mikaelarguedas mikaelarguedas deleted the homogenize_PLR_error_message branch December 29, 2023 12:45
@miccal miccal mentioned this pull request Jan 2, 2024
Merged
@mikaelarguedas mikaelarguedas mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikaelarguedas @charliermarsh