Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix continuation detection following multi-line strings #9332

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Fix continuation detection following multi-line strings #9332

merged 1 commit into from
Dec 31, 2023

Conversation

charliermarsh
Copy link
Member

Summary

The logic that detects continuations assumed that tokens themselves cannot span multiple lines. However, strings can -- even single-quoted strings.

Closes #9323.

@charliermarsh charliermarsh added bug Something isn't working fuzzer Surfaced via fuzzing. labels Dec 31, 2023
@charliermarsh charliermarsh marked this pull request as ready for review December 31, 2023 15:35
@charliermarsh charliermarsh merged commit b3789cd into main Dec 31, 2023
17 checks passed
@charliermarsh charliermarsh deleted the charlie/fuzz branch December 31, 2023 15:43
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@miccal miccal mentioned this pull request Jan 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working fuzzer Surfaced via fuzzing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule W293 cause panic
1 participant
@charliermarsh