Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect multi-segment submodule imports when resolving qualified names #9382

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Respect multi-segment submodule imports when resolving qualified names #9382

merged 1 commit into from
Jan 3, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Jan 3, 2024 •
edited

Ensures that if the user has import collections.abc, then get_or_import_symbol returns collections.abc.Iterator (or similar) when requested.

@charliermarsh charliermarsh marked this pull request as ready for review January 3, 2024 16:12
@charliermarsh
Copy link
Member Author

\cc @AlexWaygood

@charliermarsh charliermarsh added the bug Something isn't working label Jan 3, 2024
@charliermarsh charliermarsh merged commit 7b6baff into main Jan 3, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/fix branch January 3, 2024 16:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@Porkepix Porkepix mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@charliermarsh