Parenthesize breaking named expressions in match guards #9396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Jan 5, 2024
crates/ruff_python_formatter/tests/snapshots/format@statement__match.py.snap
Outdated
Show resolved
Hide resolved
charliermarsh
commented
Jan 5, 2024
crates/ruff_python_formatter/tests/snapshots/format@statement__match.py.snap
Show resolved
Hide resolved
charliermarsh
added
bug
|
MichaReiser
reviewed
Jan 5, 2024
There was a problem hiding this comment.
I feel the same as you. Maybe parenthesze is mainly intended to use for top level expressions, not for nested sub expressions.
I haven't looked at the issue (on my phone) but this is probably something that needs solving in the case formatting or we should use in_parentheses_only_softline_break in the if expression formatting
|
Let me try |
charliermarsh
force-pushed
the
charlie/parens
branch
from
f564661
to
60d72a1
Compare
|
Ok this now looks right... |
|
Nice! |
MichaReiser
approved these changes
Jan 8, 2024
|
Thank you |
Co-authored-by: Micha Reiser <micha@reiser.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an attempt to solve #9394 by avoiding breaks in named expressions when invalid.