Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some additional Python 3.12 typing members to deprecated-import #9445

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Add some additional Python 3.12 typing members to deprecated-import #9445

merged 1 commit into from
Jan 9, 2024

Conversation

charliermarsh
Copy link
Member

Closes #9443.

@charliermarsh charliermarsh changed the title Add some additional Python 3.12 typing members to deprecated-import Add some additional Python 3.12 typing members to deprecated-import Jan 9, 2024
@charliermarsh
Copy link
Member Author

@AlexWaygood - do you mind reviewing this one?

@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Jan 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh
Copy link
Member Author

\cc @AlexWaygood

AlexWaygood
AlexWaygood approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@charliermarsh charliermarsh merged commit ad1ca72 into main Jan 9, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/types branch January 9, 2024 17:52
@charliermarsh
Copy link
Member Author

Thanks for the close read!

@Porkepix Porkepix mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UP035 doesn't detect typing_extensions.override when targeting python 3.12
2 participants
@charliermarsh @AlexWaygood