Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit inplace diagnostics to methods that accept inplace #9495

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Jan 12, 2024

Summary

This should reduce false positives like #9491, by ignoring methods that are clearly not on a DataFrame.

Closes #9491.

@charliermarsh charliermarsh added the bug Something isn't working label Jan 12, 2024
Copy link

codspeed-hq bot commented Jan 12, 2024

CodSpeed Performance Report

Merging #9495 will improve performances by 4.55%

Comparing charlie/pd (7d9728b) with main (d16c4a2)

Summary

⚡ 1 improvements
✅ 29 untouched benchmarks

Benchmarks breakdown

Benchmark main charlie/pd Change
parser[numpy/ctypeslib.py] 12.8 ms 12.2 ms +4.55%

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+0 -1 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)

bokeh/bokeh (+0 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-preview --select ALL

- src/bokeh/core/serialization.py:666:34: PD002 `inplace=True` should be avoided; it has inconsistent behavior

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PD002 1 0 1 0 0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -1 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)

bokeh/bokeh (+0 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview --select ALL

- src/bokeh/core/serialization.py:666:34: PD002 `inplace=True` should be avoided; it has inconsistent behavior

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PD002 1 0 1 0 0

@charliermarsh charliermarsh merged commit fee64b5 into main Jan 12, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/pd branch January 12, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive in 0.1.12 PD002 with pyvista inplace
1 participant