Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): admonition in dark mode #9502

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

pabepadu
Copy link
Contributor

@pabepadu pabepadu commented Jan 13, 2024

Summary

The admonition in dark mode are in actually same as in light mode here: https://docs.astral.sh/ruff/formatter/#ruff-format

I propose to move admonition in real dark mode as shown below:

Close #9501

Test Plan

Documentation was regenerated via mkdocs and the supplied requirements.

@pabepadu pabepadu changed the title fix: admonition in dark mode fix(docs): admonition in dark mode Jan 13, 2024
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cc @charliermarsh I think there were some other instances of this problem in an issue but I don't remember where.

@zanieb zanieb added the documentation Improvements or additions to documentation label Jan 13, 2024
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, thanks!

@charliermarsh charliermarsh merged commit ef2798f into astral-sh:main Jan 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Admonition in dark mode
3 participants