-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: package version management with Changeset #250
Conversation
✅ Deploy Preview for astro-reactive ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for astro-reactive-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@fazzaamiarso Very interested in this. Looks like it will save us a lot of manual work. 🙏 |
@ayoayco do you want to try implement changeset manually before adding automation? So, we can get familiar with the commands beforehand. Manual changeset workflow should be similar to our usual versioning and publishing workflow. |
@fazzaamiarso Yup! Does this branch have working |
Yes, it's working. It also comes with Github action that automatically creates a versioning PR. I suggest to read the docs. Here are some useful parts. |
@fazzaamiarso Played around with changesets. Can you resolve conflicts so we can merge this? I want to test further the GH Actions. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to merge now, I think you just need to update the package lock ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah no worries, it was easy. I updated the package lock.
We're now getting a weird CI error regarding |
Hey @ayoayco Sorry I've been very busy this time around, will get back at you this week. |
Hey, no worries! Could you pick it up when you have the time? @fazzaamiarso |
@ayoayco I'm checking it now |
@fazzaamiarso 👍 - I tried some changes but really couldn't make the CI error go away. Was wondering if it's just cached, but after deleting our GH Action caches still there 🤔 |
Closing this one then |
feat: package version management with Changeset
fix #225
Description of changes:
Tag a reviewer: @ayoayco
Tasks:
npm run build
npm run test
npm run lint