Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: package version management with Changeset #250

Closed
wants to merge 13 commits into from

Conversation

fazzaamiarso
Copy link
Member

@fazzaamiarso fazzaamiarso commented Jan 4, 2023

feat: package version management with Changeset

fix #225

Description of changes:

  • install changeset cli
  • add changeset github action

Tag a reviewer: @ayoayco

Tasks:

  • I have ran the build command to make sure apps are working: npm run build
  • I have ran the tests to make sure nothing is broken: npm run test
  • I have ran the linter to make sure code is clean: npm run lint
  • I have reviewed my own code to remove changes that are not needed

@netlify
Copy link

netlify bot commented Jan 4, 2023

Deploy Preview for astro-reactive ready!

Name Link
🔨 Latest commit 421aaa7
🔍 Latest deploy log https://app.netlify.com/sites/astro-reactive/deploys/63dbdcb1c89d3d0008f02f07
😎 Deploy Preview https://deploy-preview-250--astro-reactive.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 4, 2023

Deploy Preview for astro-reactive-docs ready!

Name Link
🔨 Latest commit 421aaa7
🔍 Latest deploy log https://app.netlify.com/sites/astro-reactive-docs/deploys/63dbdcb1960f710008234373
😎 Deploy Preview https://deploy-preview-250--astro-reactive-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fazzaamiarso
Copy link
Member Author

fazzaamiarso commented Jan 4, 2023

@ayoayco I think changeset is great for version management in monorepo. Although, we must read the docs quite a bit to understand. But, it definitely improves the workflow.

I will start to add changeset bot and github action to automate. It will look something like this PR once setup.

@ayoayco
Copy link
Member

ayoayco commented Jan 5, 2023

@fazzaamiarso Very interested in this. Looks like it will save us a lot of manual work. 🙏

@fazzaamiarso
Copy link
Member Author

@ayoayco do you want to try implement changeset manually before adding automation? So, we can get familiar with the commands beforehand.

Manual changeset workflow should be similar to our usual versioning and publishing workflow.

@ayoayco
Copy link
Member

ayoayco commented Jan 10, 2023

@fazzaamiarso Yup! Does this branch have working changeset cli?

@fazzaamiarso
Copy link
Member Author

Yes, it's working. It also comes with Github action that automatically creates a versioning PR.

I suggest to read the docs. Here are some useful parts.

@ayoayco ayoayco marked this pull request as ready for review January 23, 2023 17:53
@ayoayco
Copy link
Member

ayoayco commented Jan 23, 2023

@fazzaamiarso Played around with changesets. Can you resolve conflicts so we can merge this? I want to test further the GH Actions. :)

Copy link
Member

@ayoayco ayoayco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to merge now, I think you just need to update the package lock ;)

ayoayco
ayoayco previously approved these changes Jan 23, 2023
Copy link
Member

@ayoayco ayoayco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no worries, it was easy. I updated the package lock.

@ayoayco
Copy link
Member

ayoayco commented Jan 23, 2023

We're now getting a weird CI error regarding turbo not being found for this branch. Found a discussion and their resolution was this could be a caching issue, but our current CI does not have any caches 🤔 vercel/turbo#824

@fazzaamiarso
Copy link
Member Author

Hey @ayoayco Sorry I've been very busy this time around, will get back at you this week.

@ayoayco
Copy link
Member

ayoayco commented Jan 25, 2023

Hey, no worries! Could you pick it up when you have the time? @fazzaamiarso

@fazzaamiarso
Copy link
Member Author

@ayoayco I'm checking it now

@ayoayco
Copy link
Member

ayoayco commented Feb 2, 2023

@fazzaamiarso 👍 - I tried some changes but really couldn't make the CI error go away. Was wondering if it's just cached, but after deleting our GH Action caches still there 🤔

@fazzaamiarso
Copy link
Member Author

@ayoayco I moved the PR to #261. It seems the package-lock conflict is the problem. I fresh installed changeset from the recent main branch and it worked.

@ayoayco
Copy link
Member

ayoayco commented Feb 2, 2023

Closing this one then

@ayoayco ayoayco closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: automate version management and package release
2 participants