Strip factor=None in equivalency converter for spectral density
#229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
=======================================
Coverage 97.94% 97.95%
=======================================
Files 54 54
Lines 2046 2050 +4
=======================================
+ Hits 2004 2008 +4
Misses 42 42 ☔ View full report in Codecov by Sentry. |
braingram
force-pushed
the
deprecated_factor
branch
2 times, most recently
from
0049d7c
to
28addd8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I am very surprised that |
to avoid deprecation warnings for astropy 7
braingram
force-pushed
the
deprecated_factor
branch
from
28addd8
to
8f54ebf
Compare
braingram
changed the title
factor=None in equivalency converter for spectral density
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalencies are serialized by storing the
kwargs:asdf-astropy/asdf_astropy/resources/schemas/units/equivalency-1.1.0.yaml
Line 19 in 1b28610
The
factorkeyword argument tospectral_densityis deprecated in astropy 7.0 which means:spectral_densitythat was originally created with afactorwill produce a warning when loadedfactoris removedThis PR strip
factorwhen it'sNoneto avoid the deprecation warning for astropy 7 and only testsfactorfor astropy versions older than 7.