Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Use pytest-dev for py310 in v5.0.x #12854

Merged
merged 2 commits into from Feb 15, 2022

Conversation

pllim
Copy link
Member

@pllim pllim commented Feb 14, 2022

I don't understand why this is not cropping up in main and I don't have time to dig, but it is a known issue. xref pytest-dev/pytest#9169 . As long as CI is green again, good enough until next pytest release?

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@pllim pllim added 💤 io.misc.asdf Go to asdf-astropy repo skip-changelog-checks Tells bot to skip changlog checks ¯\_(ツ)_/¯ Python3.10 skip-basebranch-check Skip base branch check for direct backports labels Feb 14, 2022
@pllim pllim added this to the v5.0.2 milestone Feb 14, 2022
@github-actions github-actions bot added testing and removed 💤 io.misc.asdf Go to asdf-astropy repo labels Feb 14, 2022
@pllim pllim added the 💤 io.misc.asdf Go to asdf-astropy repo label Feb 15, 2022
@pllim
Copy link
Member Author

pllim commented Feb 15, 2022

A lot of things broken related to ASDF here:

@pllim pllim merged commit 3560064 into astropy:v5.0.x Feb 15, 2022
@pllim pllim deleted the fix-mystery-asdf-py310-v5.0.x branch February 15, 2022 14:43
pllim added a commit to meeseeksmachine/astropy that referenced this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python3.10 skip-basebranch-check Skip base branch check for direct backports skip-changelog-checks Tells bot to skip changlog checks testing 💤 io.misc.asdf Go to asdf-astropy repo ¯\_(ツ)_/¯
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant