-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that np.concatenate with dtype argument works on quantities and masked data #13323
Ensure that np.concatenate with dtype argument works on quantities and masked data #13323
Conversation
Both failures are unrelated - see #13322 |
It hard to prove this really fixed the problem because the dev job didn't run at all. I'll see if I can make the matplotlib stuff go away. |
Actually, it is not that bad: this does test with numpy 1.20, and that had a bug already. So, that is fixed by this PR. If we then rebase yours, we can check that it also solved the numpy-dev issues. |
@mhvk , please rebase. Thanks! |
bb368dc
to
4036526
Compare
OK, rebased. Hopefully all the tests pass now! |
OK, all tests passed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…ment works on quantities and masked data
…ment works on quantities and masked data
Thanks for keeping a look-out for those |
…323-on-v5.1.x Backport PR #13323 on branch v5.1.x (Ensure that np.concatenate with dtype argument works on quantities and masked data)
…323-on-v5.0.x Backport PR #13323 on branch v5.0.x (Ensure that np.concatenate with dtype argument works on quantities and masked data)
Description
This pull request ensures
np.concatenate
will work onQuantity
andMasked
also with thedtype
argument (new since numpy 1.20); see discussion in #13322 (but relevant not just for numpy-dev).Fixes #
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CI
label.no-changelog-entry-needed
label. If this is a manual backport, use theskip-changelog-checks
label unless special changelog handling is necessary.astropy-bot
check might be missing; do not let the green checkmark fool you.backport-X.Y.x
label(s) before merge.