Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMCCE: check ephemerides parameters #1810

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

migueldvb
Copy link
Member

Validating parameters provided to Miriade.get_ephemerides and adding check to remote test.

@codecov
Copy link

codecov bot commented Aug 29, 2020

Codecov Report

Merging #1810 into master will decrease coverage by 0.48%.
The diff coverage is 80.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1810      +/-   ##
==========================================
- Coverage   64.41%   63.93%   -0.49%     
==========================================
  Files         200      200              
  Lines       16034    15784     -250     
==========================================
- Hits        10329    10092     -237     
+ Misses       5705     5692      -13     
Impacted Files Coverage Δ
astroquery/imcce/core.py 90.90% <80.00%> (-3.32%) ⬇️
astroquery/imcce/__init__.py 100.00% <100.00%> (ø)
astroquery/esa/xmm_newton/core.py 54.66% <0.00%> (-19.31%) ⬇️
astroquery/utils/tap/core.py 29.48% <0.00%> (-11.74%) ⬇️
astroquery/utils/tap/xmlparser/tableSaxParser.py 93.12% <0.00%> (-4.59%) ⬇️
astroquery/utils/tap/taputils.py 69.44% <0.00%> (-4.42%) ⬇️
astroquery/utils/tap/model/tapcolumn.py 92.30% <0.00%> (-0.55%) ⬇️
astroquery/heasarc/core.py 22.03% <0.00%> (-0.10%) ⬇️
astroquery/gaia/__init__.py 100.00% <0.00%> (ø)
astroquery/utils/tap/model/job.py 59.91% <0.00%> (+1.36%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8036b07...42dff37. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Sep 4, 2020

Hello @migueldvb! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-11-07 18:22:42 UTC

@bsipocz
Copy link
Member

bsipocz commented Feb 24, 2022

@migueldvb - could you rebase this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants