Use tracinglib::error! instead of tracinglib::info!`
#1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On [Rust forum](https://users.rust-lang.org/t/is-tracing-intended-to-be-used-as-i-am-using-it-how-can-i-trace-errors-chain/81988/2) they're helping me better understand async-graphql#1089 and found that we're calling `On [Rust forum](https://users.rust-lang.org/t/is-tracing-intended-to-be-used-as-i-am-using-it-how-can-i-trace-errors-chain/81988/2) they're helping me better understand async-graphql#1089 and found that we're calling `tracinglib::info!` instead of `tracinglib::error!` here: https://github.com/async-graphql/async-graphql/blob/974f8ff21d9019bde138f11c4eb5b1aeae554aa0/src/extensions/tracing.rs#L146. Is this wrong, right?!` instead of `tracinglib::error!` here: https://github.com/async-graphql/async-graphql/blob/974f8ff21d9019bde138f11c4eb5b1aeae554aa0/src/extensions/tracing.rs#L146. Is this wrong, right?
|
Also here: tokio-rs/tracing#2329 they suggest the |
|
Maybe we should make the error log level to an option. |
What do you mean? |
|
Add a |
I do not understand. I'm using In this code I think we are only using the Am I wrong? If I'm wrong please edit my PR: no problem at all! 😃 |
|
@sunli829 can you please merge this and release? |
sunli829
force-pushed
the
master
branch
3 times, most recently
from
7eabbe3
to
912feb3
Compare
sunli829
force-pushed
the
master
branch
2 times, most recently
from
2bf0fb8
to
1ae8831
Compare
sunli829
force-pushed
the
master
branch
2 times, most recently
from
404c7b2
to
0142d6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Rust forum they're helping me better understand #1089 and found that we're calling
tracinglib::info!instead of
tracinglib::error!here:
async-graphql/src/extensions/tracing.rs
Line 146 in 974f8ff
Is this wrong, right?