Add support for 'input_name_suffix_ in '#[graphql(...)]' (fixes #1117)

[ClementNerma]

Support for SimpleObject, InputObject, Union and Oneofobject.

Also improves refactoring:

// This:
#[derive(SimpleObject, InputObject)]
#[graphql(input_name = "TestInput")]
struct Test { /* ... */ }

// Becomes:
#[derive(SimpleObject, InputObject)]
#[graphql(input_name_suffix = "Input")]
struct Test { /* ... */ }

So when Test is renamed, the input name will be changed automatically.

[sunli829]

Thanks for the PR, but I don't think the input_name_suffix attribute simplifies anything, so I won't merge this. 🙂

[ClementNerma]

Thanks for the PR, but I don't think the input_name_suffix attribute simplifies anything, so I won't merge this. 🙂

I strongly disagree, it enables several things:

1. You don't have to play with concatenation in macros
2. This avoids relying on an external dependency just for concatenation
3. When renaming a struct, the input type will be renamed automatically as well

I think this simplifies things a lot and I'd even argue that having this argument is more important than input_name itself as it serves more use cases :)

[teenjuna]

@sunli829 are you sure? I can see why someone may want this, and the added code is quite simple. Maybe reconsider?

[bramvanneerven]

3. When renaming a struct, the input type will be renamed automatically as well

I like the change mainly because of this.

When both input_name and input_name_suffix are used at the same time (for some reason?), I think input_name should override or an error should be thrown though.

[ClementNerma]

3. When renaming a struct, the input type will be renamed automatically as well

I like the change mainly because of this.

When both input_name and input_name_suffix are used at the same time (for some reason?), I think input_name should override or an error should be thrown though.

Not necessarily, for instance you could want to give a suffix to all of your types even with a custom name.

[ClementNerma]

@sunli829 hi, I've rebased the PR to make it work with the latest 5.x versions. May you please reconsider the purpose of this add? I think it would be really useful for some people (like me) and it doesn't hurt to add it in the end for people that don't want to use it.

In my current project I constantly use my fork to have this feature which is essential.