Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I am requesting some improvements to the GraphiQL v2 source generator.
What has changed?
GraphiQLSource
struct to generate the source, instead of doing a lot of 'manual' string based manipulations. This introduces a dependency, but I think it is worth it from a long-term maintenance perspective.credentials
field to an enum. I think that is better than allowing arbitrary strings. [breaking change]endpoint
andsubscription_endpoint
are now relative urls instead of absolute ones. This matches with how routes are defined in most web frameworks;Route::new().at("/", ...)
in poem for example. This way, we do not have to know the exact origin url when developing the application, increasing the 'seperation of concerns'. [breaking change]I also created a PR to update the examples: async-graphql/examples#64.