Implement Content-Encoding aware query decompression support #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the PR, just this should be implemented by web framework? 😂 |
|
This is indeed already implemented by some web frameworks (such as Actix-web) but async-graphql bypasses this mechanism because it works on raw requests. |
sunli829
force-pushed
the
master
branch
3 times, most recently
from
7eabbe3
to
912feb3
Compare
sunli829
force-pushed
the
master
branch
2 times, most recently
from
2bf0fb8
to
1ae8831
Compare
sunli829
force-pushed
the
master
branch
2 times, most recently
from
404c7b2
to
0142d6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Content-Encoding aware decompression support for incoming GQL queries. This can be useful when dealing with large queries that compress well. This add supports for gzip, deflate, brotli and zstd compression algorithms under the new feature "compression".
Actix-web has similar features to allow the decompression of incoming requests based on the content-encoding header.
Fixes #879.