Enforce non zero capacity for channel #715
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this fails in quite a few places but I don't think those failures are related to my changes |
yoshuawuyts
requested changes
Feb 24, 2020
|
I've been doing some thinking and perhaps instead of guarding against zero we could use the type checker to make sure that we never get zero by using |
|
ah strike that, it requires to be manually wrapped, however, it could be used for the internal functions? as in the Channel struct |
k-nasa
approved these changes
Mar 9, 2020
I think it can be fixed by rebase master. |
Co-Authored-By: Yoshua Wuyts <yoshuawuyts+github@gmail.com>
Licenser
force-pushed
the
forbid-zero-size-channel
branch
from
d181398
to
3004312
Compare
|
Sorry for the late reply / rebase, got dragged into $otherrthings ™️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the function with it's documentation and will result in easier to resolve errors for problems such as #712.
closes #712