Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding default http.Client #135

Closed
atc0005 opened this issue Feb 7, 2022 · 1 comment · Fixed by #140 or #155
Closed

Allow overriding default http.Client #135

atc0005 opened this issue Feb 7, 2022 · 1 comment · Fixed by #140 or #155
Assignees
@atc0005
Labels
config documentation Improvements or additions to documentation enhancement New feature or request
Milestone
v2.7.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Feb 7, 2022 •
edited

The NewClient() function is currently used to create an opaque API "client". This client is used to send MessageCard values to Microsoft Teams.

Current support for overriding the internal http.Client is minimal. While the vast majority of use cases are handled with the default client, many consumers of this library could benefit by supplying their own customized http.Client values.
@atc0005 atc0005 added documentation Improvements or additions to documentation enhancement New feature or request config labels Feb 7, 2022
@atc0005 atc0005 added this to the Future milestone Feb 7, 2022
@atc0005 atc0005 self-assigned this Feb 7, 2022
@atc0005 atc0005 mentioned this issue Feb 7, 2022
Open
@atc0005 atc0005 modified the milestones: Future, Next Release Feb 8, 2022
atc0005 added a commit that referenced this issue Feb 8, 2022
@atc0005
Allow overriding default http.Client
884e59f 
- Add `teamsClient.SetHTTPClient()` method to allow client code
  to replace default `http.Client` with custom value
- Update `API` interface to expose new `SetHTTPClient()` method
- Light doc updates to reflect this change

refs GH-135
@atc0005 atc0005 mentioned this issue Feb 8, 2022
Merged
@atc0005 atc0005 mentioned this issue Feb 16, 2022
Closed
atc0005 added a commit that referenced this issue Feb 25, 2022
@atc0005
Revert recent API changes
7985ea0 
OVERVIEW

- Revert "Allow overriding default http.Client"
- Revert "Set project-specific user agent, offer override"

REFERENCES

- 884e59f
- 26ac7b4
- GH-134
- GH-135
- GH-139
atc0005 added a commit that referenced this issue Feb 25, 2022
@atc0005
Revert recent API changes
710d8b2 
OVERVIEW

- Revert "Allow overriding default http.Client"
- Revert "Set project-specific user agent, offer override"

REFERENCES

- 884e59f
- 26ac7b4
- GH-134
- GH-135
- GH-139
@atc0005 atc0005 mentioned this issue Feb 25, 2022
Merged
atc0005 added a commit that referenced this issue Feb 25, 2022
@atc0005
Revert recent API changes
943dc5c 
OVERVIEW

- Revert "Allow overriding default http.Client"
- Revert "Set project-specific user agent, offer override"

REFERENCES

- 884e59f
- 26ac7b4
- GH-134
- GH-135
- GH-149
@atc0005 atc0005 modified the milestones: v2.7.0, v2.8.0 Feb 25, 2022
@atc0005
Copy link
Owner Author

atc0005 commented Feb 25, 2022

Changes reverted via #151. Reopening to track implementation in next release.

@atc0005 atc0005 reopened this Feb 25, 2022
@atc0005 atc0005 mentioned this issue Feb 25, 2022
Closed
atc0005 added a commit that referenced this issue Feb 25, 2022
@atc0005
Deprecate API interface, add user mention support
59c75e0 
Summary:

- deprecate the current `API` interface
- expose `TeamsClient` to take its place
- create common interfaces and helper code to abstract any specific
  Microsoft Teams message format
- create new `botapi` package (limited functionality)
- extend existing `MessageCard` type (where needed) type to support
  new behavior
- port existing `goteamsnotify.MessageCard` types/functions/methods to
  a new `messagecard` package and deprecate existing `MessageCard`
  functionality provided by the `goteamsnotify` "base" package
- update examples to reflect changes
- restore support for overriding default `http.Client`
- restore default project-specific user agent, support for
  overriding the default from client code

While making these changes I've refactored code and attempted to
clearly communicate which existing code/functionality is being
deprecated, all without introducing breaking changes for client code.

The `botapi` package added in this collection of changes is a minimal
implementation. This package is intended to provide limited user
mention functionality for channel updates as a "bridge" until future
`Adaptive Card` support can be implemented.

A future implementation of `Adaptive Card` support would provide a
more complete experience, presumably providing a superset of the
limited support in the `botapi` package and existing `MessageCard`
functionality.

refs GH-127
refs GH-134
refs GH-135
refs GH-154
@atc0005 atc0005 mentioned this issue Feb 25, 2022
Merged
@nikoksr nikoksr mentioned this issue Mar 22, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
config documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
v2.7.0
1 participant
@atc0005