Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding default http.Client #140

Merged
merged 1 commit into from Feb 8, 2022
Merged

Allow overriding default http.Client #140

merged 1 commit into from Feb 8, 2022

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Feb 8, 2022

  • Add teamsClient.SetHTTPClient() method to allow client code to replace default http.Client with custom value
  • Update API interface to expose new SetHTTPClient() method
  • Light doc updates to reflect this change

fixes GH-135

@atc0005
Allow overriding default http.Client
884e59f 
- Add `teamsClient.SetHTTPClient()` method to allow client code
  to replace default `http.Client` with custom value
- Update `API` interface to expose new `SetHTTPClient()` method
- Light doc updates to reflect this change

refs GH-135
@atc0005 atc0005 added enhancement New feature or request config labels Feb 8, 2022
@atc0005 atc0005 added this to the Next Release milestone Feb 8, 2022
@atc0005 atc0005 self-assigned this Feb 8, 2022
@atc0005 atc0005 merged commit b23746c into master Feb 8, 2022
@atc0005 atc0005 deleted the i135-allow-overriding-default-http-client branch February 8, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@atc0005 atc0005

Labels
config enhancement New feature or request
Projects
None yet
Milestone
v2.6.1
Development

Successfully merging this pull request may close these issues.

Allow overriding default http.Client
1 participant
@atc0005