Simplify validation, resolve gocognit warnings #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create internal validation helper and use it to replace existing validation logic used in methods identified by gocognit. The end result is that the larger, more complex validation methods are (hopefully) more concise and readable now. I began the process of replacing the logic used by other validation methods with validation helper calls, but have not finished the conversion work. I plan to return to this with a future PR once I've reviewed the remaining (unconverted) validation logic further. Credit to Fabrizio Milo for sharing the original implementation: - https://stackoverflow.com/a/23960293/903870 - https://github.com/Mistobaan refs GH-157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create internal validation helper and use it to replace existing
validation logic used in methods identified by gocognit. The end
result is that the larger, more complex validation methods are
(hopefully) more concise and readable now.
I began the process of replacing the logic used by other validation
methods with validation helper calls, but have not finished the
conversion work. I plan to return to this with a future PR once
I've reviewed the remaining (unconverted) validation logic further.
Credit to Fabrizio Milo for sharing the original implementation:
refs GH-157