Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further validation refactoring #175

Merged
merged 1 commit into from Jul 12, 2022
Merged

Further validation refactoring #175

merged 1 commit into from Jul 12, 2022

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Jul 12, 2022

  • rename validation package back to original name of
    validator
    • attempting to follow the guideline of naming a package
      based on what it provides, not what it does
  • drop "Must" prefix from validation methods in an effort to make the
    method names sound more natural
  • add Validator.NoNilValuesInCollection method
  • add validation handling for ColumnItems type alias ([]*Element)
  • use Validator methods for validation of Column type

Further refactoring could be beneficial, as would further conversion
of Validate method implementations to use of the validator package.

refs GH-157

@atc0005
Further validation refactoring
1c255b7 
- rename `validation` package back to original name of
  `validator`
  - attempting to follow the guideline of naming a package
    based on what it provides, not what it does
- drop "Must" prefix from validation methods in an effort to make the
  method names sound more natural
- add Validator.NoNilValuesInCollection method
- add validation handling for ColumnItems type alias ([]*Element)
- use Validator methods for validation of Column type

Further refactoring could be beneficial, as would further conversion
of Validate method implementations to use of the validator package.

refs GH-157
@atc0005 atc0005 added this to the v2.7.0 milestone Jul 12, 2022
@atc0005 atc0005 self-assigned this Jul 12, 2022
@atc0005 atc0005 merged commit 8214fc2 into master Jul 12, 2022
@atc0005 atc0005 deleted the i157-further-validation-refactoring branch July 12, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@atc0005 atc0005

Labels
card format/adaptivecard Adaptive Card support validation
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@atc0005