Remove invalid errors.As() usage, name test cases #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove errors.As() comparison logic until I can determine how to use a table test configuration to reliably assert that an expected error is of a specific type. Tweak test failure message format slightly to improve readability. Add `name` field to table test struct, move test name comments from each table test into name value (so that each test case is properly labeled in output). Run each test case as a subtest in an effort to provide additional isolation. refs GH-176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove errors.As() comparison logic until I can determine how to use a table test configuration to reliably assert that an expected error is of a specific type.
Tweak test failure message format slightly to improve readability.
Add
namefield to table test struct, move test name comments from each table test into name value (so that each test case is properly labeled in output).Run each test case as a subtest in an effort to provide additional isolation.
fixes GH-176