Fixed mosaic_support.sh #30
Conversation
- Added support for all browsers for both Linux and Mac by opening the about:blank page. - Automatically kill browser processes - Ability to specify directly from the binary which website to open, with fallback to about:blank such that no connections are made
|
Hi there! Thank you very much for your contribution. Your work most definitely deserves points (and personal thanks from CN team). It looks good and as by me your PR idea is great but we would like to test it's working before we merge which we will do in the next couple of days! Thank you for your understanding |
| @@ -0,0 +1,29 @@ | |||
| #!/bin/bash | |||
|
|
|||
| DEFAULT_WEBSITE="about:blank" | |||
There was a problem hiding this comment.
Change the default website to example.org / example.com
| for BROWSER_BIN in "${BROWSER_BINS[@]}"; do | ||
| if command -v "$BROWSER_BIN" &>/dev/null; then | ||
| killall -9 "$BROWSER_BIN" &>/dev/null | ||
| fi | ||
| done |
There was a problem hiding this comment.
Can we do the trick without killing all the open browsers?
There was a problem hiding this comment.
I thought about this: can we actually just terminate the script asking the user to shut down their browser in case one is open instead of killing the process (output which browser they have to terminate as well)? We would avoid confusion among the people whose browser is all of the sudden turned off this way
Currently, both
mosaic-supportscripts openchromeby default and make it very hard for users that do not have a good understanding of filesystems to locate thekeylogfile.txtfile.This pull request adds support for opening the default browser instead and also set the
SSLKEYLOGFILEenvironment variable to point to the current directory.The changes are only implemented for Linux (and partially for Mac), but I intend to modify both the Mac and Windows part of the script(s).