Output folder structure #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radu-Nicolae
force-pushed
the
output-folder-structure
branch
2 times, most recently
from
d3cf1ee
to
05b8656
Compare
unversioned filed pushed spotless applied code cleaned up commit before pr spotless applied setupOutputFolder moved before getting the scenarios specific topology added pretty tracking given scenarios are kept track by id code runnable output name for scenario updated python folder and src document connected simulationOutputFolder structure prepared base for python script integration in simulations output contents into a folder defined by the simulation name output contents into a folder defined by the simulation name
Radu-Nicolae
force-pushed
the
output-folder-structure
branch
from
05b8656
to
0730065
Compare
…lved (now we use the output folder indicated in scenario.json input file)
DanteNiewenhuis
requested changes
May 1, 2024
| import ScenarioTopologySpec | ||
| import WorkloadSpec | ||
| import org.opendc.experiments.base.models.scenario.ScenarioWriter |
There was a problem hiding this comment.
I think this is an incorrect inport, it should be base.scenario.ScenarioWriter
...endc-experiments-base/src/main/kotlin/org/opendc/experiments/base/scenario/ScenarioWriter.kt
Outdated
Show resolved
Hide resolved
DanteNiewenhuis
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simulations are now stored in an output folder, with a well-defined structure. The simulations are tracked by ID.
Each simulation ID is tracked into the trackr.json.
Implementation Notes ⚒️
During the process of getting scenarios, we define a folder with the following structure.
_- outputFolderName
External Dependencies 🍀
N/A
Breaking API Changes⚠️
Yes, the output folders were changed.