Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Collect UI test coverage report and upload to CircleCI #2096

Merged
merged 1 commit into from
May 21, 2020
Merged

chore: Collect UI test coverage report and upload to CircleCI #2096

merged 1 commit into from
May 21, 2020

Conversation

igarashitm
Copy link
Member

Fixes: #2075

@netlify
Copy link

netlify bot commented May 21, 2020 •
edited

Remember, in order to test the stories for the core package you need to have Atlasmap standalone running on your machine on the default port (8585). Eg. java -jar standalone/target/atlasmap-standalone.jar

Built with commit 29edb51

https://deploy-preview-2096--atlasmap.netlify.app

riccardo-forina
riccardo-forina approved these changes May 21, 2020
View reviewed changes
Copy link
Collaborator

@riccardo-forina riccardo-forina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Do we also have a way to consult the result?

@igarashitm
Copy link
Member Author

It could be found in CircleCI build artifacts, but it might be better to publish upstream master results as a part of developer guide as well. I'll try that.

@igarashitm
Copy link
Member Author

ugh now even @atlasmap/atlasmap test fails with exit code 137... and adding --runInBand causes this one - jsdom/jsdom#2961

@igarashitm
Copy link
Member Author

@riccardo-forina @gashcrumb it seems this globalThis not defined issue in JSDOM only happens with node v10
https://stackoverflow.com/questions/60976511/globalthis-underfined-for-jest-test-cases

Do you guys see any problem if we switch to node v12?

@riccardo-forina
Copy link
Collaborator

I guess it’s worth a shot. I’m syndesis we are stuck with v10 for reasons I haven’t investigated yet

@igarashitm
Copy link
Member Author

No problem with node v12 for local build, fingers crossed...

@igarashitm igarashitm merged commit f12c074 into atlasmap:master May 21, 2020
@igarashitm igarashitm deleted the 2075 branch May 21, 2020 22:16
@igarashitm
Copy link
Member Author

I'll continue on #2098 for dev guide migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riccardo-forina riccardo-forina riccardo-forina approved these changes

@pleacu pleacu Awaiting requested review from pleacu

Assignees
No one assigned
Labels
pr/wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collect UI test coverage report and upload to CircleCI
2 participants
@igarashitm @riccardo-forina