Backend OTLP: Adding OTLP as a configurable backend for GoStatsD #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MovieStoreGuy
commented
Jan 11, 2024
Excaleo
previously requested changes
Jan 11, 2024
Excaleo
reviewed
Jan 11, 2024
Excaleo
reviewed
Jan 11, 2024
MovieStoreGuy
force-pushed
the
msg/add-consuming-metrics
branch
from
008923b
to
69a647a
Compare
MovieStoreGuy
force-pushed
the
msg/add-consuming-metrics
branch
from
69a647a
to
3a97091
Compare
|
I've parked the additional actions, I would like to follow up on those to be done within the transport instead of within the encoding step. |
MovieStoreGuy
force-pushed
the
msg/add-consuming-metrics
branch
from
3a97091
to
7d31e1d
Compare
hstan
reviewed
May 23, 2024
| func newDefaultConfig() *Config { | ||
| return &Config{ | ||
| Transport: "default", | ||
| MaxRequests: runtime.NumCPU() * 2, |
There was a problem hiding this comment.
So it really depends on the backend supporting out of order writes, if it does, you can open this up wide, otherwise, restricting it is a good idea.
…atsd into limit-concurrent-req-n-batch
Limit the amount of concurrent request to `maxRequests`
hstan
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This adds in support for OTLP as a supported backend for Gostatsd however it does come with some limitations:
Events will need to be exported as logs which currently isn't written yet and ignored for this PR.
Migration
To ensure the highest amount of compatibility with other configurable backends, timers can either exported as Gauges with the calculated value added as suffix to the metric. This should ensure that existing metrics being emitted to your configured backend should maintain the same semantic value when visualising / evaluating within metrics platform.
Outstanding