Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --config resolving #278

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix --config resolving #278

wants to merge 2 commits into from

Conversation

ReDrUm
Copy link
Collaborator

@ReDrUm ReDrUm commented Mar 28, 2022

Stricter CLI exposes the -c and --config flags, similar to ESLint, however they weren't functional.

The default behaviour of not specifying a config path correctly finds the root config, but when specifying a path it'd throw an error claiming to not find the file.

Additionally, fixes an import to fix allow opting into the debug logger.

const logger = isCi ? getNullLogger() : getDebugLogger();

@ReDrUm
Copy link
Collaborator Author

ReDrUm commented Mar 28, 2022

What's the process for contributing, versioning, and publishing now that this is open source? I don't see a guide in the README.md.

@ReDrUm ReDrUm assigned Blasz and marcodejongh and unassigned Blasz Mar 28, 2022
@Li0liQ
Copy link
Contributor

Li0liQ commented Mar 28, 2022

TravisCI is configured to publish a new version once it finds a new tag (see https://github.com/atlassian/stricter/blob/master/.travis.yml#L20-L21).
I.e. you merge the changes into master, update the version in package.json and add a changelog. After that you create and push a new tag. Once it lands, TravisCI will deploy a new version automatically.

@marcodejongh
Copy link
Collaborator

@Li0liQ You better not rotate your npm keys then, or did you use an Atlassian bot user for publishing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants