Skip to content

Commit

Permalink
Prepare v1.2.2 release
Browse files Browse the repository at this point in the history
  • Loading branch information
suda committed Mar 12, 2020
1 parent 2fd2645 commit 7d73122
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
@@ -1,6 +1,6 @@
{
"name": "tool-bar",
"version": "1.2.1",
"version": "1.2.2",
"description": "Package providing customisable tool bar",
"keywords": [
"toolbar",
Expand Down

5 comments on commit 7d73122

@aminya
Copy link
Member

@aminya aminya commented on 7d73122 Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish you had increased the version to 1.3 instead. Since a couple of new features was introduced in this version.

@suda
Copy link
Collaborator Author

@suda suda commented on 7d73122 Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were no breaking changes tho. I'm trying to keep the versioning semver compliant.

@aminya
Copy link
Member

@aminya aminya commented on 7d73122 Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the original Semvar https://semver.org/ suggests this:

MINOR version when you add functionality in a backward-compatible manner
PATCH version when you make backward-compatible bug fixes.

These were not bug fixes

@suda
Copy link
Collaborator Author

@suda suda commented on 7d73122 Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, you're right. IDK why I thought otherwise 🤔

@aminya
Copy link
Member

@aminya aminya commented on 7d73122 Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can still publish a newer version (1.3) and remove the old tag from Github.

Please sign in to comment.