fix build on apple silicon #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
approved these changes
Apr 10, 2021
|
@cdaguerre Nodejs doesn't fully support Apple Silicon yet, and there are no CI services that I can test this on. Are you able to make me a prebuild for the next major release of Zadeh? Related to: |
|
@aminya thanks for merging so quickly! |
|
Than you for your contribution. Yes, but I will need it for the next release which will be major one. |
|
@aminya ok sure, just let me know. |
|
Whenever #58 is finished. If you need the Apple Silicon fixes sooner, I can backport it to v2. |
|
@aminya that would be great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea why but this is needed to build on apple silicon