Add missing subclasses to .markup and remove .gfm specific styling #444
Conversation
| @@ -277,6 +279,7 @@ atom-text-editor .search-results .marker.current-result .region, | |||
| font-style: italic; | |||
| } | |||
|
|
|||
| &.heading, | |||
| &.heading .punctuation.definition.heading { | |||
There was a problem hiding this comment.
What's actually an example for &.heading .punctuation.definition.heading? I can't find where that gets used. Maybe we can remove it and just have &.heading.
There was a problem hiding this comment.
I have no idea. Just remove it, and hope nobody notices anything?
From the default languages, the only one with .heading is markdown, right?
There was a problem hiding this comment.
When doing a search I can only find it in this file: https://github.com/atom/language-coffee-script/blob/master/grammars/coffeescript%20(literate).cson#L131. Seems like for when Markdown is used in a CoffeeScript file? History doesn't reveal much either.
Just remove it, and hope nobody notices anything?
Yeah, I would say so. It sounds really specific for a "base" selector. And is probably used only to override .heading .something.
There was a problem hiding this comment.
Is there any spec that gives an example for this? If not, I'd say remove it.
There was a problem hiding this comment.
There is https://manual.macromates.com/en/language_grammars#naming_conventions, but doesn't go deeper than .markup.heading.
There was a problem hiding this comment.
I'll take the blame if this destroys the world, okay?
There was a problem hiding this comment.
😄 Will be fine. And we can always add it back if it's really crucial.
See atom/one-dark-syntax#50 for more details.
This change shouldn't affect any syntax-themes (unless they have really specific scopes) as
language-gfmalready uses the more generic.markupclasses./cc @simurai