Simplify icon param for Electron Packager

atom · Sep 16, 2017 · c26b510 · c26b510
1 parent 299b9ed
commit c26b510
Showing 1 changed file with 1 addition and 14 deletions.
diff --git a/script/lib/package-application.js b/script/lib/package-application.js
@@ -26,7 +26,7 @@ module.exports = function () {
     electronVersion: CONFIG.appMetadata.electronVersion,
     extendInfo: path.join(CONFIG.repositoryRootPath, 'resources', 'mac', 'atom-Info.plist'),
     helperBundleId: 'com.github.atom.helper',
-    icon: getIcon(),
+    icon: path.join(CONFIG.repositoryRootPath, 'resources', 'app-icons', CONFIG.channel, 'atom'),
     name: appName,
     out: CONFIG.buildOutputPath,
     overwrite: true,
@@ -120,19 +120,6 @@ function getAppName () {
   }
 }
 
-function getIcon () {
-  switch (process.platform) {
-    case 'darwin':
-      return path.join(CONFIG.repositoryRootPath, 'resources', 'app-icons', CONFIG.channel, 'atom.icns')
-    case 'linux':
-      // Don't pass an icon, as the dock/window list icon is set via the icon
-      // option in the BrowserWindow constructor in atom-window.coffee.
-      return null
-    default:
-      return path.join(CONFIG.repositoryRootPath, 'resources', 'app-icons', CONFIG.channel, 'atom.ico')
-  }
-}
-
 function runPackager (options) {
   return electronPackager(options)
     .then(packageOutputDirPaths => {