Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

no mnemonics in menus (File, Edit, ...) #6666

Closed
kolAflash opened this issue May 6, 2015 · 13 comments · Fixed by #18916 or #18603
Closed

no mnemonics in menus (File, Edit, ...) #6666

kolAflash opened this issue May 6, 2015 · 13 comments · Fixed by #18916 or #18603
Labels
bug electron linux Issues that occur on Linux but not on other platforms.

Comments

@kolAflash
Copy link

My system:
Linux
Desktop: KDE 4.14.6

In the menus there are any mnemonics shown at all!
(the menu buttons themselves show mnemonics when pressing ALT)
E.g. in File menu:

New Window
New File
Open File
...

don't show any mnemonics. Also when pressing "ALT" while menu is opened.
Nevertheless, mnemonics seem to be there (but not shown). If I press "n" while in File menu (found out by guessing) Atom opens a new file.

@50Wliu 50Wliu added enhancement linux Issues that occur on Linux but not on other platforms. labels May 6, 2015
@kolAflash
Copy link
Author

Guess this is not just an enhancement but a bug! Because on Windows there are mnemonics in the menus.

Additionally tested this on Kubuntu 14.04. It also has that bug!

Nevertheless, on Ubuntu 14.04 with Unity the mnemonics in the menu are displayed correctly. Probably, because the menu is rendered by Unity in the Unity-Systembar (or also the window titlebar).
After switching off the menu rendering by Unity (apt-get remove indicator-appmenu) the bug also appears in Unity... :-/

Maybe this is related:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-bugs/FgE4vTD8JbM

@50Wliu 50Wliu added bug and removed enhancement labels May 7, 2015
@kolAflash
Copy link
Author

Anyone else having this issue?

I don't think it's hard to find the reason for this if you have some knowledge of the source (which I unfortunately don't have).

@dead-claudia
Copy link

I don't have the issue. I'm running Ubuntu GNOME 14.04, 64-bit.

@kolAflash
Copy link
Author

This is what it looks like for me on Ubuntu GNOME 15.10.

Pressing ALT to show mnemonics. Now Atom shows a mnemonic for each menu.
alt-pressed

Pressing ALT-F to open the File menu. But there are no more mnemonics. Either for the different menus (File, Edit, View, ...) nor for the entries in the menus ("New Window", "New File", "Open File", ...).
menu-opened

Pressing just ALT on Windows (8.1) looks the same.
alt-pressed_win

But pressing ALT-F on Windows also gives mnemonics in the menus.
menu-opened_win

@dead-claudia
Copy link

I can confirm on Ubuntu 15.10 as well. It's inconvenient on rare occasion,
but in practice I hardly notice. Low priority for me to want fixed.

On Tue, Feb 23, 2016, 02:10 kolAflash notifications@github.com wrote:

This is what it looks like for me on Ubuntu GNOME 15.10.

Pressing ALT to show mnemonics. Now Atom shows a mnemonic for each menu.
[image: alt-pressed]
https://cloud.githubusercontent.com/assets/3355089/13243948/e5222078-da02-11e5-9e57-40d9629a59ff.png

Pressing ALT-F to open the File menu. But there are no more mnemonics.
Either for the different menus (File, Edit, View, ...) nor for the entries
in the menus ("New Window", "New File", "Open File", ...).
[image: menu-opened]
https://cloud.githubusercontent.com/assets/3355089/13243950/e897cca8-da02-11e5-9243-c4ccca90bd25.png

Pressing just ALT on Windows (8.1) looks the same.
[image: alt-pressed_win]
https://cloud.githubusercontent.com/assets/3355089/13244206/a5f8f1c2-da04-11e5-8f5f-cb5aa51c8cae.png

But pressing ALT-F on Windows also gives mnemonics in the menus.
[image: menu-opened_win]
https://cloud.githubusercontent.com/assets/3355089/13244217/b56d7ad8-da04-11e5-9ac9-f9649c0c2fa1.png


Reply to this email directly or view it on GitHub
#6666 (comment).

@rivis
Copy link

rivis commented Jan 8, 2017

I have the same issue.

Atom: 1.12.9
OS: Debian GNU/Linux 8.6 (jessie)
Desktop: Xfce4 4.10

This issue was the largest blocker for me to move to Atom from other editors because I usually use the menu by mnemonic key strokes to run commands which don't have key-bindings or I can't remember key-bindings of.

Until the issue is fixed, I wrote a script in $HOME/.atom/init.js to show mnemonics in menu labels.

(() => {
    let appendMnemonic = (menuList) => {
        menuList.forEach((menu) => {
            if (menu.label) {
                let amp = menu.label.indexOf('&');
                if (amp >= 0) {
                    let mnemonic = menu.label.charAt(amp + 1).toUpperCase();
                    menu.label = `${menu.label}  (${mnemonic})`;
                }
            }
            if (menu.submenu) {
                appendMnemonic(menu.submenu);
            }
        })
    }
    appendMnemonic(atom.menu.template);
    atom.menu.update();
})();

atom-mnemonics

@jsolisu
Copy link

jsolisu commented Jan 8, 2017

I don´t have the issue on Windows 10.

@50Wliu
Copy link
Contributor

50Wliu commented Jan 8, 2017

I don´t have the issue on Windows 10.

Yep, because this is a Linux-only bug.

@stale
Copy link

stale bot commented Jan 8, 2018

Thanks for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. Because the Atom team treats their issues as their backlog, stale issues are closed. If you would like this issue to remain open:

  1. Verify that you can still reproduce the issue in the latest version of Atom
  2. Comment that the issue is still reproducible and include:
    • What version of Atom you reproduced the issue on
    • What OS and version you reproduced the issue on
    • What steps you followed to reproduce the issue

Issues that are labeled as triaged will not be automatically marked as stale.

@stale stale bot added the stale label Jan 8, 2018
@kolAflash
Copy link
Author

Bug is still existing in 1.23.3 without any changes to what I previously reported.

@stale stale bot removed the stale label Jan 10, 2018
@daviwil
Copy link
Contributor

daviwil commented Jan 24, 2019

Looks like this has been fixed by Electron 3 based on a quick check using my Manjaro Linux machine! Keep an eye on this PR for when the Electron 3 upgrade is complete: #18603

@50Wliu
Copy link
Contributor

50Wliu commented Mar 15, 2019

New Electron 3 PR is #18916.

@50Wliu 50Wliu reopened this Mar 15, 2019
@lock
Copy link

lock bot commented Nov 16, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug electron linux Issues that occur on Linux but not on other platforms.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants