⬆️ Electron 3 (Take Two) #18916

jasonrudolph · 2019-02-26T22:23:23Z

Description of the Change

#18603 and #18815 upgraded Atom from Electron 2 to Electron 3, but we unfortunately experienced frequent crashes following those changes. As a short-term solution, #18908 reverted those changes.

This pull request restores the changes from #18603 and #18815. (It does so by reverting the changes from #18908.) Before we merge this pull request, we'll need to resolve the crashes that led to us having to revert the previous Electron 3 upgrade.

Issues to resolve

I think these issues are all caused by the upgrade to Electron 3. If we discover that they're not directly related to the Electron 3 upgrade, we can remove them from this list and address them separately.

Fixes #6666.
Fixes #18535.
Fixes atom/tabs#544

Related commit: electron/electron@3ac4c1f

This dependency is no longer needed now that we use Node's built-in APIs

In Chrome 66+ it seems that getComputedStyle().fontWeight returns the computed numeric value of the style instead of the original descriptive name. We now look for value '700' which corresponds to the value of 'bold'.

More info here: https://developers.google.com/web/updates/2018/03/cssom

package.json

as-cii · 2019-05-16T19:26:09Z

I also think we should consider looking into how text is being rendered in this new version before shipping it. Below you can find a zoomed-in screenshot of rendering the word Lorem in a variety of environments. Please, click on all of the images and quickly browse through the tabs to appreciate how stark the difference is for this pull request.

Atom on Electron 3 (this pull request)

VS Code on Electron 3 (latest published version)

Atom on Electron 2 (Atom 1.38.0-beta0)

You can reproduce the above tests by using Fira Code Retina, 15px. I suspect some of the styling we do in TextEditorComponent is interacting oddly with the new Chromium version.

jasonrudolph · 2019-05-16T19:36:40Z

I also think we should consider looking into how text is being rendered in this new version before shipping it.

Thanks, @as-cii. I've added this to the task list in the PR body.

as-cii · 2019-05-17T15:05:34Z

@rafeca and I think this pull request is ready to be merged. The sooner we do this, the more time we will have to catch bugs before it goes to Beta. Please, note that we are purposely ignoring #18915 for now because we haven't been able to reproduce it, and it's unclear how it would be related to the Electron upgrade.

Feedback on this is super welcome! Especially after this pull request gets merged, it would be useful to get as many 👀 on Nightly as possible to catch potential regressions that we didn't notice.

/cc: @atom/maintainers

jasonrudolph · 2019-05-17T15:16:09Z

@rafeca and I think this pull request is ready to be merged.

Have you had a chance to run through the regression test plan? Once we've tested out all the items on that checklist, I'm 👍 on merging this pull request.

It's a pretty long checklist, so I'd be perfectly happy to divide and conquer with y'all.

Arcanemagus · 2019-05-17T23:10:22Z

Note: The libgconf-2-4 dependency to be added in #19358 will need to be removed when this is merged, as Electron 3 doesn't require it.

as-cii · 2019-05-20T09:38:14Z

Check for regressions experienced in previous upgrades

Verify that you can collaborate with Teletype
- Host using Atom's current stable release can collaborate with guest using Atom with the new version of Electron
- Guest using Atom's current stable release can collaborate with host using Atom with the new version of Electron
- Host and guest can collaborate when both are using Atom with the new version of Electron
Steps
1. Open a file 1. Share a portal 1. Have a guest join the portal 1. When guest edits the text in the file, verify that the host sees those changes

Text Input/Keybindings

See how to setup keyboard layouts.

IME not working (1.19.0-beta2: Cursor stucks at the first letter when using macOS Chinese IME #14911)
- macOS
- Windows 10
- Ubuntu
Repro steps
1. Install an IME layout, for example Pinyin simplified
2. Open Atom and use the layout you installed as the keyboard layout
3. Example, if you picked Pinyin simplified type in zhongwenshuru
Expected: in Pinyin simplified 中文输入 is expected

Issues we've seen: Only shows latin first character and not every character typed.
macOS: Key binding with composition characters are ignored (key-mappings with alt don't suppress Mac OS composition characters anymore (atom-1.19) #15189)
Repro steps
1. Open your keymap.cson file and add the following:
```
'atom-text-editor':
  # use hjkl; vim-like when pressing alt (word by word, paragraph by paragraph)
  # or alt (letter by letter)
  'alt-h': 'core:move-left'
  'alt-j': 'core:move-down'
  'alt-k': 'core:move-up'
  'alt-l': 'core:move-right'
```
2. Save keymap.cson and reload atom.
3. Try the new keymappings under ABC - Extended keyboard layout
Expected: the keybindings work

Issues we've seen: it types out the modified keys and ignores the key mapping
macOS: Composition characters mess up insertion point (Composition characters mess up insertion point #15344)
Repro steps
1. Open keymap.cson and add the following:
```
'atom-text-editor':
  'alt-n': 'core:move-down'
  'alt-o': 'core:move-down'
```
2. Have the following in your buffer:
```
Foo
Bar
```
3. Have the cursor at the beginning of file(before F character) Type alt-n, then arrow right, then insert a character. Observe that the character is inserted at the beginning of the line (where the alt-n left you).
4. Repeat steps using alt-o instead of alt-n.
Expected: Both alt-o and alt-n behave the same

Issues we've seen:
Ubuntu: Keystrokes involving ctrl resolve to the default layout instead of the active layout (Keystrokes involving ctrl on Linux resolve to the default layout instead of the active layout #13170)
Repro steps

This should be tested on Linux with gnome
1. Install a Linux ditro with gnome, for example Ubuntu
2. Install French AZERTY and English US QWERTY layouts
3. Change the default layout to be French AZERTY
4. Open Atom and switch to English US QWERTY layout
5. Press ctrl-w
Expected: core:close to dispatch (Or the keybinding-resolver to resolve to ctrl-w). Should be resolving to the keyboard layout that is chosen and not the OS default layout.

Issues we've seen: core:undo dispatched because it was resolved as ctrl-z because AZERTY has Z where W is on QWERTY.
Other keyboard layouts on new Electron version
- macOS: ABC - Extended
- macOS: Slovak
- macOS: U.S. International
- macOS: Squirrel (https://github.com/rime/squirrel)
- macOS: Full-Width Alphanumeric (Google) - Japanese layout (https://www.google.co.jp/ime/)
- Windows: U.S.
- Linux: Pinyin Simplified

UI

Other

rafeca · 2019-05-20T11:59:23Z

I've done the sanity checks on Linux and haven't found any regression related to this upgrade. I have some notes though about some items:

Large file rendering (#16591)

I've tried with a several million lines file and the editor becomes almost unresponsive (good thing is that Atom shows a warning saying that the file is too big and may cause issues with the editor). When I tried to scroll to ~800k line Atom ended up crashing.

This same behaviour happened on current Atom beta, so it's not an electron issue.

Scrolling horizontally shift + scroll wheel (#12696 (comment))

I'm not able to test this one because I don't have a wheel mouse.

Middle clicking on unsaved tab (#15197)

I'm not able to test this one because I don't have a wheel mouse.

nathansobo · 2019-05-20T19:39:34Z

Probable regression: #19372

This reverts commit dc39210, reversing changes made to e18559f.

nathansobo · 2019-05-20T22:36:35Z

Hate to have to say this, but I reverted this in 3da827b due to crashes related to #19372. The saga continues.

This reverts commit 3da827b.

jasonrudolph mentioned this pull request Feb 26, 2019

Revert to Electron 2 until we can overcome crashes on Electron 3 #18908

Merged

4 tasks

This comment has been minimized.

Sign in to view

rsese mentioned this pull request Mar 8, 2019

Items in the Menu Bar are invisible on Ubuntu 18.10 when atom window is focused. #18535

Closed

1 task

This comment has been minimized.

Sign in to view

jasonrudolph mentioned this pull request Mar 14, 2019

Atom built from source (v1.34) crashes when opening a folder with git repository #18926

Closed

50Wliu mentioned this pull request Mar 15, 2019

no mnemonics in menus (File, Edit, ...) #6666

Closed

scherii mentioned this pull request Mar 15, 2019

Constant crashing on 0.2.1 simurai/one-vibrancy#18

Open

lee-dohm mentioned this pull request Mar 18, 2019

Atom gives a quick white blink/flickering when you do something #15323

Closed

rsese mentioned this pull request Mar 19, 2019

Freeze when dragging tabs (confirmed with 1.32.1) atom/tabs#544

Closed

This was referenced Mar 28, 2019

Iteration Plan: March 18 - March 29, 2019 #19011

Closed

Update Node to match Electron 3.1 atom/apm#831

Merged

BenRussert mentioned this pull request Apr 15, 2019

Update dependency electron to v3.1.9 nteract/nteract#4302

Merged

1 task

rafeca mentioned this pull request May 7, 2019

Unable to delete files on Fedora 28 (gvfs-trash is deprecated) #17452

Open

1 task

daviwil and others added 9 commits May 13, 2019 13:52

Update snapshot path from snapshot_blob to v8_context_snapshot

525d252

Related commit: electron/electron@3ac4c1f

Use the new Electron 3.0 snapshotting process with mksnapshot

1066430

Launch mksnapshot.js using the current Node

7770ae2

Remove cached-run-in-this-context and use Node's 'vm' script caching

552bb22

Remove cached-run-in-this-context dependency

262354d

This dependency is no longer needed now that we use Node's built-in APIs

Change chromedriver/mksnapshot version check to only lock major version

2316b74

Use correct fontWeight value in ThemeManager spec

9921e18

In Chrome 66+ it seems that getComputedStyle().fontWeight returns the computed numeric value of the style instead of the original descriptive name. We now look for value '700' which corresponds to the value of 'bold'.

Use new attributeStyleMap for elements

75d9a30

More info here: https://developers.google.com/web/updates/2018/03/cssom

⬆️ electron@3.1.8

99af15e

rafeca force-pushed the electron-3.1 branch from 211eb26 to 99af15e Compare May 13, 2019 14:16

Merge branch 'master' into electron-3.1

2b15c1e

rafeca mentioned this pull request May 14, 2019

Enabling @atom/notify by default causes CI failures with electron v3 #19333

Closed

mfonville reviewed May 14, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

jasonrudolph added 2 commits May 14, 2019 16:50

⬆️ electron@3.1.9

b2a4810

⬆️ electron-chromedriver@3.0.0

6e2c0b0

This comment has been minimized.

Sign in to view

rafeca mentioned this pull request May 17, 2019

"Open link" stopped working #19353

Closed

This comment has been minimized.

Sign in to view

as-cii mentioned this pull request May 17, 2019

Text Rendering on macOS changed with Electron 3.0 #19356

Closed

as-cii marked this pull request as ready for review May 17, 2019 14:59

as-cii merged commit dc39210 into master May 20, 2019

as-cii deleted the electron-3.1 branch May 20, 2019 13:20

Arcanemagus mentioned this pull request May 20, 2019

Update .deb package dependencies #19358

Merged

nathansobo added the electron-3 Tasks related to upgrade to electron v3 label May 20, 2019

nathansobo pushed a commit that referenced this pull request May 20, 2019

Revert "Merge pull request #18916 from atom/electron-3.1"

3da827b

This reverts commit dc39210, reversing changes made to e18559f.

nathansobo restored the electron-3.1 branch May 20, 2019 23:42

as-cii deleted the electron-3.1 branch May 21, 2019 15:25

as-cii pushed a commit that referenced this pull request May 21, 2019

Revert "Revert "Merge pull request #18916 from atom/electron-3.1""

8e2e262

This reverts commit 3da827b.

as-cii mentioned this pull request May 30, 2019

Upgrade to Electron 3.1.10 #19419

Merged

Arcanemagus mentioned this pull request Jun 24, 2019

Address libnode vulnerability #19583

Closed

Redsandro mentioned this pull request Oct 25, 2019

Update to Electron 5, 6, or 7 BoostIO/BoostNote-Legacy#3122

Closed

thomas-nilsson-irfu mentioned this pull request Jan 15, 2020

Atom still require "deprecated command-line tools" gvfs-bin, why? #20320

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

⬆️ Electron 3 (Take Two) #18916

⬆️ Electron 3 (Take Two) #18916

jasonrudolph commented Feb 26, 2019 •

edited by as-cii

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

as-cii commented May 16, 2019 •

edited

jasonrudolph commented May 16, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

as-cii commented May 17, 2019

jasonrudolph commented May 17, 2019

Arcanemagus commented May 17, 2019

as-cii commented May 20, 2019 •

edited by jasonrudolph

rafeca commented May 20, 2019

nathansobo commented May 20, 2019

nathansobo commented May 20, 2019

⬆️ Electron 3 (Take Two) #18916

⬆️ Electron 3 (Take Two) #18916

Conversation

jasonrudolph commented Feb 26, 2019 • edited by as-cii

Description of the Change

Issues to resolve

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

as-cii commented May 16, 2019 • edited

Atom on Electron 3 (this pull request)

VS Code on Electron 3 (latest published version)

Atom on Electron 2 (Atom 1.38.0-beta0)

jasonrudolph commented May 16, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

as-cii commented May 17, 2019

jasonrudolph commented May 17, 2019

Arcanemagus commented May 17, 2019

as-cii commented May 20, 2019 • edited by jasonrudolph

Check for regressions experienced in previous upgrades

Text Input/Keybindings

UI

Other

rafeca commented May 20, 2019

nathansobo commented May 20, 2019

nathansobo commented May 20, 2019

jasonrudolph commented Feb 26, 2019 •

edited by as-cii

as-cii commented May 16, 2019 •

edited

as-cii commented May 20, 2019 •

edited by jasonrudolph