This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Don't create a promise when preloading package settings in snapshot #19418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Promise creation is forbidden within `mksnapshot` (see electron/libchromiumcontent#363, nodejs/node#13242 and electron/electron#18420). Since preloading a package's settings is a synchronous action anyway, we just avoid instantiating a new Promise when calling `loadSettings`.
|
I think the failures are unrelated to this pull request, so I'll go ahead and merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19374
Promise creation is forbidden within
mksnapshotstarting from Electron 3 (see electron/libchromiumcontent#363, nodejs/node#13242 and electron/electron#18420). Since preloading a package's settings is a synchronous action anyway, we just avoid instantiating a new Promise when callingloadSettings.This fixes the crashes we were observing in #19373 when generating a new snapshot, and it is a prerequisite for shipping the Electron 3 upgrade after a hotfix with electron/electron#18426 is released.