This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Send OS version to the autoupdate endpoint #19607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafeca
added a commit
that referenced
this pull request
Jul 2, 2019
Send OS version to the autoupdate endpoint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Atom is going to be upgraded to use Electron v4 (PR: #19373), and since that new version of Electron does not support OSX < 10.10, we need to make users of older OSX versions to stick to a version of Atom that uses Electron v3.
Solution
We're going to add some custom logic on the autoupdate backend to force clients on older OSX versions to stick to the latest Atom stable/beta/nightly version that uses Electron v3.
In order to do so, we need to send the
os_versionparameter to the autoupdate backend, which is what this PR is doing 馃槂More information in this comment.