refine workaround for node ABI issue with Electron install

[shiftkey]

This builds upon #154 now that Electron has bumped the ABI for v4 to 69 in electron/node@8bc5d17 which is available in Electron 4.0.4.

The patches applied to prebuild-install are here: prebuild/prebuild-install@099c704...8723b8b but the important part is the runtime check:

if (rc.runtime === 'electron' && rc.target[0] === "4" && rc.abi === "64") {
  log.error(`Electron version ${rc.target} found - skipping prebuild-install work due to known ABI issue`)
  log.error('More information about this issue can be found at https://github.com/lgeiger/node-abi/issues/54')
  process.exit(1)
}

This check now means prebuild-install aborts when:

• it's the Electron runtime
• the target is in the 4.x.x series
• the ABI associated with it is the known incorrect one

TODO:

• test against 4.0.4 build -> ✅ (upgrade node-abi and prebuild for newest v4 with correct Electron ABI #157 will generate these with the next update)

prebuild-install WARN install No prebuilt binaries found (target=4.0.4 runtime=electron arch=x64 libc= platform=darwin)

• test against 4.0.3 build -> ❌

prebuild-install ERR! Electron version 4.0.3 found - skipping prebuild-install work due to known ABI issue
prebuild-install ERR! More information about this issue can be found at https://github.com/lgeiger/node-abi/issues/54

[daviwil]

Looks good to me! I wonder if it makes sense to PR this change upstream since the real fix only applies to 4.0.4+? Lots of people will be having this same issue.

[shiftkey]

@daviwil yeah, it's not a problem that's going to resolve itself unless people upgrade to the latest Electron 4.x versions. I can open a PR to see if upstream is interested in accepting the workaround in the interim.

[shiftkey]

Upstreamed the workaround: prebuild/prebuild-install#95