This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Cover trash failures for macOS and Windows with a message #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lee-dohm
force-pushed
the
better-error-message
branch
from
869dac3
to
22c06ea
Compare
50Wliu
reviewed
Jan 2, 2017
| switch process.platform | ||
| when 'linux' then 'Is `gvfs-trash` installed?' | ||
| when 'darwin' then 'Is Trash enabled on the volume where the files are stored?' | ||
| when 'win32' then 'Is RecycleBin support enabled on the drive where the files are stored?' |
There was a problem hiding this comment.
Recycle Bin should be two words. An alternative wording could also be Is there a Recycle Bin on the drive where the files are stored?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Deleting files from the Tree View can fail if the volume, drive or share doesn't support the platform's implementation of a "trash". Because this occurs much more frequently on Linux, we previously covered this with an enhanced error message in #695. This problem can still occur on Windows or macOS though and people on those platforms deserve a better error message to give them some idea of why Atom is unable to delete their files for them.
Alternate Designs
Considered returning more information from Electron's
shell.moveItemToTrashfunction so that it could be detected if it was truly a trash problem or some other failure to delete the file. Adding support for better error conditions in a cross-platform way is beyond the scope of my time and abilities though, so this is what I opted for.Benefits
Possible Drawbacks
Applicable Issues