This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
feat: Add a command to delete items permanently #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
changed the title
aminya
changed the title
aminya
force-pushed
the
permanently-delete
branch
2 times, most recently
from
283345c
to
2c1f70b
Compare
This will be used in the next commit
aminya
force-pushed
the
permanently-delete
branch
2 times, most recently
from
788c650
to
ed3e763
Compare
aminya
force-pushed
the
permanently-delete
branch
4 times, most recently
from
540afa1
to
6b500f7
Compare
aminya
force-pushed
the
permanently-delete
branch
from
6b500f7
to
e3a5650
Compare
sadick254
reviewed
Apr 8, 2021
aminya
force-pushed
the
permanently-delete
branch
from
daad82d
to
c3c0430
Compare
aminya
commented
Apr 8, 2021
aminya
commented
Apr 8, 2021
aminya
force-pushed
the
permanently-delete
branch
from
c3c0430
to
18729a3
Compare
aminya
force-pushed
the
permanently-delete
branch
from
18729a3
to
c868589
Compare
|
I don't know why the test failed again. It was working 😥 Writing tests with CoffeeScript 1 and Jasmine 1 is a very bad experience. |
aminya
force-pushed
the
permanently-delete
branch
from
66a0d3c
to
098a195
Compare
|
The issue was that I was comparing arrays and objects together using |
aminya
force-pushed
the
permanently-delete
branch
from
098a195
to
52a572b
Compare
|
Thanks for the contribution 🙇🏾♂️ . Could you fix the conflicts? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This adds a command to delete items permanently. It uses the Sift+delete shortcut similar to operating system shortcuts. It prompts before doing so.
Benefits
Applicable Issues
This PR does not provide an alternative trashing implementation for tree-view:remove, but it provides a new command to avoid these issues by using tree-view:remove-permanently. In later PRs, we can use the trash package as a fallback to fix and close these issues:
#1368
#1237
#345
#1046
Possible Drawbacks
none