fix: ensure duplicate components are written to unique files #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hey there, thanks for the contrib! The changes are a bit difficult to follow due to formatting changes. I'll pick the functional bits and merge them in. I'll LYK when it's published |
|
Urgh sorry, the pre-commit hook must have used a newer version of prettier, i can put the style changes back if you like? The functional changes are 109 - 131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our project we have components that are wrapped which means docgen detects components with the same name. This patch makes sure that each component is written to a unique file. Currently if two components have the same name then stringified props get concatenated together resulting in invalid json.