Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update appendTo docs to be inline with code/other docs #1026

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jasikpark
Copy link

export const TIPPY_DEFAULT_APPEND_TO = () => document.body;

This is a docs change to update the description of the default setting for appendTo

@atomiks
Copy link
Owner

atomiks commented Jan 8, 2022

The current docs are correct as the condition is "If interactive: true"

@jasikpark
Copy link
Author

Oh! I didn't see that at all 😅 It looked like the default in the text and the default in the example code described two different defaults

@atomiks
Copy link
Owner

atomiks commented Jan 8, 2022

Yeah tbh the wording could be better. Like describe the actual default, then the default with the condition.

@jasikpark
Copy link
Author

I'll update my PR w/ that wording if that works! That seems like a good way to make it less confusing to me :)

@jasikpark
Copy link
Author

Only took me 7mo to update 😅

@jasikpark
Copy link
Author

anything i can do to push this PR to being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants