Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #754

Merged
merged 12 commits into from
Mar 5, 2023
Merged

Windows support #754

merged 12 commits into from
Mar 5, 2023

Conversation

YummyOreo
Copy link
Contributor

Adds support for windows in atuin.

Things that windows can't support:

  • atuin import auto This is because windows does not have anything equivalent to $SHELL

Ps. I totally get if you guys don't want to support this.

@vercel
Copy link

vercel bot commented Mar 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
atuin ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 5, 2023 at 6:47PM (UTC)

@ellie
Copy link
Member

ellie commented Mar 2, 2023

Ps. I totally get if you guys don't want to support this.

😆

I've been thinking about this a bunch lately. My only issue with us supporting Windows is that neither me nor @conradludgate regularly use a Windows machine, so Windows releases would not get properly tested at all.

However... it has been mentioned, a lot. Here and in a several other PRs and issues. If we're able to find a few users happy to run main and keep reasonably up to date, then this is something I'd consider, probably with some caveat in the README that Windows is not as thoroughly tested. Plus with Crossterm in place now, there's probably far fewer issues.

@conradludgate thoughts?

@ellie
Copy link
Member

ellie commented Mar 2, 2023

Otherwise - regardless of whether we end up supporting Windows or not, thank you so much for the work! <3

@ellie
Copy link
Member

ellie commented Mar 2, 2023

For continuity - last mentioned in #631

@YummyOreo
Copy link
Contributor Author

However... it has been mentioned, a lot. Here and in a several other PRs and issues. If we're able to find a few users happy to run main and keep reasonably up to date

Yeah, I am happy to run main but I know that probably not enough.

Copy link
Collaborator

@conradludgate conradludgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised so little had to change

src/command/client/search/interactive.rs Outdated Show resolved Hide resolved
src/command/client/import.rs Outdated Show resolved Hide resolved
@YummyOreo
Copy link
Contributor Author

I'm surprised so little had to change

Same. I'm going to pull main and test the new bash import later today

@YummyOreo
Copy link
Contributor Author

can confirm that bash import works and command prev works

@ellie
Copy link
Member

ellie commented Mar 5, 2023

I have absolutely no way of testing this just yet so will need to get access to a Windows machine before releasing, but am comfortable to say that support is "experimental" for now 🚀

Thank you so much for this work @YummyOreo, really appreciate it!

@ellie ellie merged commit e9c5e1d into atuinsh:main Mar 5, 2023
@ellie
Copy link
Member

ellie commented Mar 5, 2023

I'll follow up with docs and stuff later, need to figure out a nice way of wording it so people don't expect us to 100% support Windows

@YummyOreo
Copy link
Contributor Author

I'll follow up with docs and stuff later, need to figure out a nice way of wording it so people don't expect us to 100% support Windows

I can help with the docs. Also it could be worded as partial support or not tested.

@YummyOreo YummyOreo mentioned this pull request Mar 14, 2023
@YummyOreo YummyOreo deleted the windows-support branch April 13, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants