Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WavPack export: include MD5 audio checksum (-m option) #5635

Open
YZgitter opened this issue Nov 16, 2023 · 4 comments · May be fixed by #5948
Open

WavPack export: include MD5 audio checksum (-m option) #5635

YZgitter opened this issue Nov 16, 2023 · 4 comments · May be fixed by #5948
Labels
Enhancement Request Or feature requests. Open-ended requests are better suited for discussions. feature tweak small changes in functionality good first issue Issues suitable for first-time contributors. See https://github.com/audacity/audacity/contribute import-export

Comments

@YZgitter
Copy link

Your idea

WavPack files can store a MD5 checksum of the audio (just like FLAC). I think Audacity should do this by default.

Problem to be solved

Integrity verification is important, especially for a format like WavPack, which is often used for lossless archival.

Prior art

No response

Additional context

No response
@YZgitter YZgitter added the Enhancement Request Or feature requests. Open-ended requests are better suited for discussions. label Nov 16, 2023
@LWinterberg
Copy link
Member

are there any drawbacks whatsoever to storing that bit of metadata? If all it does is add like 60 bytes worth of metadata to the file which can safely be ignored if you don't need it, it indeed would make sense to just plop it in

@YZgitter
Copy link
Author

Encoding is probably a bit slower because of the calculation, but I really doubt that it's a significant, perceptible difference (I didn't do any measurements, however).

@LWinterberg LWinterberg added feature tweak small changes in functionality import-export labels Nov 17, 2023
@LWinterberg LWinterberg added the good first issue Issues suitable for first-time contributors. See https://github.com/audacity/audacity/contribute label Dec 1, 2023
@dg-no-9
Copy link
Contributor

dg-no-9 commented Feb 12, 2024

Can I work on this item since it is labeled as 'good first issue'?

@LWinterberg
Copy link
Member

@dg-no-9 absolutely. And if anyone else comes across this: Just submit a PR if you've figured it out :)

@dg-no-9 dg-no-9 linked a pull request Feb 13, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Request Or feature requests. Open-ended requests are better suited for discussions. feature tweak small changes in functionality good first issue Issues suitable for first-time contributors. See https://github.com/audacity/audacity/contribute import-export
Projects
Feature Requests
Status: timeline: 3.x
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MD5 checksum added by default on wavpack exports dg-no-9/audacity
3 participants
@dg-no-9 @LWinterberg @YZgitter