-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MD5 checksum added by default on wavpack exports #5948
base: master
Are you sure you want to change the base?
Conversation
I don't believe this is sufficient. The wavpack documentation states:
Simply passing the argument as you did here just sets the flag which promises there will be an MD5 sum in the file ( My file for reference
|
@LWinterberg Thanks for note. Yes, Wavpack API seem to require MD5 from the application itself. I see that wavpack/cli has its own md5 for their testing I suppose. Do we have any MD5 library, if not we probably need to add it to support this feature. |
I see an md5 thing in some of the vendored libraries still in lib-src/, but probably not one which wants to be used here. Adding md5 to libraries/lib-crypto might be worthwhile. |
Resolves: WavPack export: include MD5 audio checksum (-m option)
The Flag 'CONFIG_MD5_CHECKSUM' set to the exporter API config. The exported wavpack files should have MD5 checksums by default after this fix.
Recommended: