Per track meters #5861
Open
Per track meters #5861
+2,429
−1,877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paul-Licameli
added
the
Experimental
|
I just tested on W10 your branch: audacity-win-3.5.0-alpha-20240112+5d1bafd-x64 The per track meters seem to work properly. One thing to note: just like the main meters these per track meters can only be reset by stopping and restarting: See: #5658 |
|
The per track meters do not work while recording: |
... The real work happens only in AILAProcess which is still not called without the experimental flag turned on.
... see also f509d9c where GetMaxPeak became unused
... also consistency of signatures with the pure virtuals of MeterPanelBase
... Don't emit start events until success is known. Only ProjectAudioManager cared, and anyway ignored start events.
... Control areas are narrower, for WaveTrack. For other kinds of tracks, which don't have meters, the control areas are now wider.
Paul-Licameli
force-pushed
the
PerTrackMeters
branch
from
28c2480
to
72f5faf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: (direct link to the issue)
(short description of the changes and the motivation to make the changes)
Recommended: