Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Time (CurrentPosition) into GetInfo command #6152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonata
Copy link
Contributor

@jonata jonata commented Mar 20, 2024

Resolves: part 1 of #6159

It wont fix the issue, but would help external apps to get the current position of the cursor and show the video accordingly.

  • I signed CLA
  • The title of the pull request describes an issue it addresses
  • If changes are extensive, then there is a sequence of easily reviewable commits
  • Each commit's message describes its purpose and effects
  • There are no behavior changes unnecessary for the stated purpose of the PR

Recommended:

  • Each commit compiles and runs on my machine without known undesirable changes of behavior

@LWinterberg LWinterberg added this to the Audacity 3.6 milestone Apr 10, 2024
@dozzzzer
Copy link
Contributor

dozzzzer commented Apr 25, 2024

I've noticed that the number of digits in the fractional part is different.

macOS:

image

Windows:

image

@LWinterberg @jonata Is this expected?

@LWinterberg
Copy link
Member

@LWinterberg @jonata Is this expected?

I'd say that a tenth of a second probably is a tad coarse for an API. I'd personally expect the Windows result every time.

@dozzzzer
Copy link
Contributor

@jonata moving the PR back to To-Do. See the comments above.

@jonata
Copy link
Contributor Author

jonata commented May 22, 2024

I can only test on Linux here. It's working:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To-Do
Development

Successfully merging this pull request may close these issues.

None yet

3 participants